From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] website : ...
Date: Fri, 08 May 2015 12:45:42 +0200
Message-ID: <87oalvl549.fsf@gnu.org>
References: <87egmr7lro.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yqfmw-0003Vm-Kc
	for guix-devel@gnu.org; Fri, 08 May 2015 06:45:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yqfmr-0000wR-Mr
	for guix-devel@gnu.org; Fri, 08 May 2015 06:45:50 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34608)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yqfmr-0000wN-Cm
	for guix-devel@gnu.org; Fri, 08 May 2015 06:45:45 -0400
In-Reply-To: <87egmr7lro.fsf@openmailbox.org> (Mathieu Lirzin's message of
	"Fri, 08 May 2015 06:09:47 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org

Could you create yourself an account on Savannah so I can add you to the
project?  That will make it easier to work on these changes.

Mathieu Lirzin <mthl@openmailbox.org> skribis:

> From 8d61be9cdd787265b7bb7e1232546f5e7f3997e3 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Thu, 7 May 2015 21:21:02 +0200
> Subject: [PATCH 1/3] website: Enable directory choice in export procedure.

OK.

> From 4763ec6706b9f5088b00f3b99f4e3eca57b05d8a Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Fri, 8 May 2015 00:06:03 +0200
> Subject: [PATCH 2/3] website: Factorize shared blocks.

OK.

> From c36af581753b015f31a562d2fe8992465d15f36e Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Fri, 8 May 2015 04:56:17 +0200
> Subject: [PATCH 3/3] website: Fix URLs.

[...]

> -				 (a (@ (href "http://www.gnu.org/philosophy/free-sw.html")
> +				 (a (@ (href "https://www.gnu.org/philosophy/free-sw.html")

I think this should be (gnu-url "philosophy/free-sw.html"), which would
return =E2=80=9C/philosophy/free-sw.html=E2=80=9D by default (with a =E2=80=
=98gnu.org-root=E2=80=99
parameter object.)

> -			      (a (@ (href "/software/guix/download/")
> +			      (a (@ (href ,(url-base "/download"))

Maybe (base-url "download") would be clearer.

> +		    (img (@ (src ,(img-url "h-separator-darker.png"))

s/img-url/image-url/

> +(define current-url-root
> +  (make-parameter "/home/mthl/src/gnu/guix-artwork/website/build"))

Rather default to =E2=80=9C/software/guix=E2=80=9D.

> +(define resources-url-root
> +  (make-parameter "https://www.gnu.org/s/guix"))

Default to (current-url-root).

OK for me with these changes.

Thank you!

Ludo=E2=80=99.