unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: guix-devel@gnu.org
Subject: Re: 01/03: gnu: ikiwiki: Revert to standard wrapper.
Date: Tue, 02 Jun 2020 09:26:06 +0100	[thread overview]
Message-ID: <87o8q150wx.fsf@cbaines.net> (raw)
In-Reply-To: <20200601191737.45A2520A26@vcs0.savannah.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]


guix-commits@gnu.org writes:

> pgarlick pushed a commit to branch master
> in repository guix.
>
> commit a0362fdea9369b7927704e48cfc6c578213019ce
> Author: Paul Garlick <pgarlick@tourbillion-technology.com>
> AuthorDate: Thu May 28 10:34:40 2020 +0100
>
>     gnu: ikiwiki: Revert to standard wrapper.
>
>     * gnu/packages/web.scm (ikiwiki)[arguments]: Remove
>     unnecessary 'include-PERL5LIB-in-wrapper' phase.  The PERL5LIB
>     environment variable may be set in the user's setup file instead.
> ---
>  gnu/packages/web.scm | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 6467184..b020a6f 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -4850,15 +4850,6 @@ NetSurf project.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> -         (add-after 'unpack 'include-PERL5LIB-in-wrapper
> -           (lambda _
> -             (substitute* "IkiWiki/Wrapper.pm"
> -               (("^@wrapper\\_hooks")
> -                (string-append
> -                 "@wrapper_hooks\n"
> -                 "        addenv(\"PERL5LIB\", \""
> -                 (getenv "PERL5LIB")
> -                 "\");")))))
>           (add-after 'patch-source-shebangs 'patch-Makefiles
>             (lambda _
>               (substitute* "Makefile.PL"

Hi Paul,

So if I remember correctly, this was added so that the Ikiwiki CGI
functionality works, and the commit message mentions this [1]

1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=f4dd303282dc0bfd88606e383c0cf98f3742f771

Can you confirm if this is still the case with this change?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

       reply	other threads:[~2020-06-02  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200601191735.15328.13392@vcs0.savannah.gnu.org>
     [not found] ` <20200601191737.45A2520A26@vcs0.savannah.gnu.org>
2020-06-02  8:26   ` Christopher Baines [this message]
2020-06-02  8:29     ` 01/03: gnu: ikiwiki: Revert to standard wrapper Christopher Baines
2020-06-02 12:29       ` Paul Garlick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8q150wx.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=guix-devel@gnu.org \
    --cc=pgarlick@tourbillion-technology.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).