From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KAGBIzEN1l6zNAAA0tVLHw (envelope-from ) for ; Tue, 02 Jun 2020 08:26:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gFplHzEN1l4/JwAAbx9fmQ (envelope-from ) for ; Tue, 02 Jun 2020 08:26:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED9F694036B for ; Tue, 2 Jun 2020 08:26:24 +0000 (UTC) Received: from localhost ([::1]:46620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2Fb-0004FI-Oq for larch@yhetil.org; Tue, 02 Jun 2020 04:26:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg2FU-0004F6-6i for guix-devel@gnu.org; Tue, 02 Jun 2020 04:26:16 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:54093) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2FT-0000w7-3E for guix-devel@gnu.org; Tue, 02 Jun 2020 04:26:15 -0400 Received: from localhost (unknown [46.237.173.126]) by mira.cbaines.net (Postfix) with ESMTPSA id 1604927BBE1; Tue, 2 Jun 2020 09:26:13 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 03e2cd44; Tue, 2 Jun 2020 08:26:09 +0000 (UTC) References: <20200601191735.15328.13392@vcs0.savannah.gnu.org> <20200601191737.45A2520A26@vcs0.savannah.gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Paul Garlick Subject: Re: 01/03: gnu: ikiwiki: Revert to standard wrapper. In-reply-to: <20200601191737.45A2520A26@vcs0.savannah.gnu.org> Date: Tue, 02 Jun 2020 09:26:06 +0100 Message-ID: <87o8q150wx.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/02 04:26:13 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: Y+DT60A+feSV --=-=-= Content-Type: text/plain guix-commits@gnu.org writes: > pgarlick pushed a commit to branch master > in repository guix. > > commit a0362fdea9369b7927704e48cfc6c578213019ce > Author: Paul Garlick > AuthorDate: Thu May 28 10:34:40 2020 +0100 > > gnu: ikiwiki: Revert to standard wrapper. > > * gnu/packages/web.scm (ikiwiki)[arguments]: Remove > unnecessary 'include-PERL5LIB-in-wrapper' phase. The PERL5LIB > environment variable may be set in the user's setup file instead. > --- > gnu/packages/web.scm | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 6467184..b020a6f 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -4850,15 +4850,6 @@ NetSurf project.") > (arguments > `(#:phases > (modify-phases %standard-phases > - (add-after 'unpack 'include-PERL5LIB-in-wrapper > - (lambda _ > - (substitute* "IkiWiki/Wrapper.pm" > - (("^@wrapper\\_hooks") > - (string-append > - "@wrapper_hooks\n" > - " addenv(\"PERL5LIB\", \"" > - (getenv "PERL5LIB") > - "\");"))))) > (add-after 'patch-source-shebangs 'patch-Makefiles > (lambda _ > (substitute* "Makefile.PL" Hi Paul, So if I remember correctly, this was added so that the Ikiwiki CGI functionality works, and the commit message mentions this [1] 1: http://git.savannah.gnu.org/cgit/guix.git/commit/?id=f4dd303282dc0bfd88606e383c0cf98f3742f771 Can you confirm if this is still the case with this change? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7WDR5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xcdbw//YMDF+m0rq32OP8kdrhYaAtqPN1ZedgRJfUYyGARFnw62qHDUU2XbChwk pfeesowRM3MV9/EtEQXZYixgpS6t3Ccl+3TtctiN3yVHU20zh2MbqzsV84DwbfYd L3FRGZtuB51wsu+EDMhTZhMB2J/+a86Knjrl2cKy7RfjVAwVr/R3J++a6/8WUIpq XWXH5h2Xl0FZ2fm5ErFc6+p74EDCCTmNB97GJPsnhqUeUB2u+scEd5aB27zVdptk Ag2MSv4hMpBW1EePeSvZWG419mbOhePZdpz3p4vV/j13wTBPmLjf91iLVCeuaNsk mEZR8VkZ7vAFhm+yQ69uv5f81a9UuoBtQ8EYBs82Hq2J7Hkcg5u0vtwe2ab2dAeU tOMxtBNzB2vlpzDE8mKsqkRCfdHSTgOzVPCwsCx8yJiWgP98J5Y5qcTLhyXaCSIv W1WzxnURZ6nD08O45oBpZk6382ybBn4mXIAU3JjRWmeBYZx1rTJkOHL5fyVWaXWo ia33LhH5yukMh3ThzFD7y2DjNteX4cAAS9Uc5P10HYDwBD3MGeqNglNLBoA6mnwM 1TVngYYBYMzEhNay9BOOfg40TFGC6MGd3YhXiYOg3MPoa7psd5pzgP3erVhWT8OB wFANxR6Bwo1tK+v7eFmDqu4nZxTcKJfJs4aYOiKq9Zt0PNnFp48= =PuR9 -----END PGP SIGNATURE----- --=-=-=--