unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add adwaita-icon-theme.
Date: Tue, 12 May 2015 22:16:53 +0200	[thread overview]
Message-ID: <87mw19y2iy.fsf@gnu.org> (raw)
In-Reply-To: <1431427501-25929-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Tue, 12 May 2015 18:45:01 +0800")

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable.

[...]

> +(define-public adwaita-icon-theme
> +  (package (inherit gnome-icon-theme)
> +    (name "adwaita-icon-theme")
> +    (version "3.16.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1cbfdypxfg74krqrklh4za64jhvskbp206l14fs739cw14xsvj53"))))
> +    (native-inputs
> +     ;; XXX: gtk-encode-symbolic-svg lacks SVG support.
> +     (alist-delete "gtk+" (package-native-inputs gnome-icon-theme)))))

Why is this ‘alist-delete’ needed?  Perhaps you just need to expound the
comment.

Also, I think specific ‘synopsis’ and ‘description’ need to be provided.

WDYT?

Thanks,
Ludo’.

  reply	other threads:[~2015-05-12 20:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 10:45 [PATCH] gnu: Add adwaita-icon-theme 宋文武
2015-05-12 20:16 ` Ludovic Courtès [this message]
2015-05-13  1:19   ` 宋文武
2015-05-13  7:55     ` Ludovic Courtès
2015-05-19  8:51       ` 宋文武
2015-05-22 13:16         ` Ludovic Courtès
2015-05-23  3:35           ` 宋文武
2015-05-23  5:33             ` Mark H Weaver
2015-05-23 22:11               ` Ludovic Courtès
2015-05-26  9:46                 ` 宋文武
  -- strict thread matches above, loose matches on Subject: below --
2015-05-14  7:38 Federico Beffa
2015-05-22  1:35 ` 宋文武
2015-05-22  7:23   ` Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mw19y2iy.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).