From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add adwaita-icon-theme.
Date: Tue, 12 May 2015 22:16:53 +0200
Message-ID: <87mw19y2iy.fsf@gnu.org>
References: <1431427501-25929-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YsGbr-0001Hp-Ds
	for guix-devel@gnu.org; Tue, 12 May 2015 16:17:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YsGbo-0001aZ-6U
	for guix-devel@gnu.org; Tue, 12 May 2015 16:16:59 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38452)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YsGbo-0001aV-3z
	for guix-devel@gnu.org; Tue, 12 May 2015 16:16:56 -0400
In-Reply-To: <1431427501-25929-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Tue, 12 May 2015 18:45:01 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable.

[...]

> +(define-public adwaita-icon-theme
> +  (package (inherit gnome-icon-theme)
> +    (name "adwaita-icon-theme")
> +    (version "3.16.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1cbfdypxfg74krqrklh4za64jhvskbp206l14fs739cw14xsvj53"))=
))
> +    (native-inputs
> +     ;; XXX: gtk-encode-symbolic-svg lacks SVG support.
> +     (alist-delete "gtk+" (package-native-inputs gnome-icon-theme)))))

Why is this =E2=80=98alist-delete=E2=80=99 needed?  Perhaps you just need t=
o expound the
comment.

Also, I think specific =E2=80=98synopsis=E2=80=99 and =E2=80=98description=
=E2=80=99 need to be provided.

WDYT?

Thanks,
Ludo=E2=80=99.