[PATCH] gnu: Add pwgen.

[PATCH] gnu: Add pwgen.

[Steve Sprang]

[-- Attachment #1.1: Type: text/plain, Size: 154 bytes --]

Suggestions for a more appropriate module or module name?

I will hopefully be adding pass (http://www.passwordstore.org/) in a
subsequent patch.

-Steve

[-- Attachment #1.2: Type: text/html, Size: 257 bytes --]

[-- Attachment #2: pwgen.patch --]
[-- Type: text/x-patch, Size: 2729 bytes --]

From 54acc1b8327291b66120cc83e03b140c242393aa Mon Sep 17 00:00:00 2001
From: Steve Sprang <scs@stevesprang.com>
Date: Tue, 18 Aug 2015 11:09:03 -0700
Subject: [PATCH] gnu: Add pwgen.

* gnu/packages/password-utils.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                   |  1 +
 gnu/packages/password-utils.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 gnu/packages/password-utils.scm

diff --git a/gnu-system.am b/gnu-system.am
index 9f46f7b..6a086dc 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -239,6 +239,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/ots.scm				\
   gnu/packages/package-management.scm		\
   gnu/packages/parallel.scm			\
+  gnu/packages/password-utils.scm		\
   gnu/packages/patchutils.scm			\
   gnu/packages/pciutils.scm			\
   gnu/packages/pcre.scm				\
diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
new file mode 100644
index 0000000..e13495f
--- /dev/null
+++ b/gnu/packages/password-utils.scm
@@ -0,0 +1,43 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages password-utils)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages))
+
+(define-public pwgen
+  (package
+    (name "pwgen")
+    (version "2.07")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/pwgen/pwgen-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "0mhmw700kkh238fzivcwnwi94bj9f3h36yfh3k3j2v19b0zmjx7b"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f))
+    (home-page "http://pwgen.sourceforge.net/")
+    (synopsis "Password generator")
+    (description "Pwgen generates passwords which can be easily memorized by a
+human.")
+    (license license:gpl1)))
-- 
2.4.3

Re: [PATCH] gnu: Add pwgen.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On Tue, 18 Aug 2015 11:16:08 -0700
Steve Sprang <steve.sprang@gmail.com> wrote:

> Suggestions for a more appropriate module or module name?

Looks good to me. I was planning on packaging KeyPassX one of these days, and
I really didn't want to stick it in keypassx.scm.

> I will hopefully be adding pass (http://www.passwordstore.org/) in a
> subsequent patch.
> 
> -Steve

-Efraim
-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: Add pwgen.

[Mark H Weaver]

Steve Sprang <steve.sprang@gmail.com> writes:

> From 54acc1b8327291b66120cc83e03b140c242393aa Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Tue, 18 Aug 2015 11:09:03 -0700
> Subject: [PATCH] gnu: Add pwgen.
>
> * gnu/packages/password-utils.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu-system.am                   |  1 +
>  gnu/packages/password-utils.scm | 43 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 gnu/packages/password-utils.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 9f46f7b..6a086dc 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -239,6 +239,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/ots.scm				\
>    gnu/packages/package-management.scm		\
>    gnu/packages/parallel.scm			\
> +  gnu/packages/password-utils.scm		\
>    gnu/packages/patchutils.scm			\
>    gnu/packages/pciutils.scm			\
>    gnu/packages/pcre.scm				\
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
> new file mode 100644
> index 0000000..e13495f
> --- /dev/null
> +++ b/gnu/packages/password-utils.scm
> @@ -0,0 +1,43 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages password-utils)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix download)
> +  #:use-module (guix packages))
> +
> +(define-public pwgen
> +  (package
> +    (name "pwgen")
> +    (version "2.07")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/pwgen/pwgen-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32 "0mhmw700kkh238fzivcwnwi94bj9f3h36yfh3k3j2v19b0zmjx7b"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f))

Please add a comment saying why tests are disabled.  In this case, maybe:

    (arguments
     `(#:tests? #f))  ; no test suite

> +    (home-page "http://pwgen.sourceforge.net/")
> +    (synopsis "Password generator")
> +    (description "Pwgen generates passwords which can be easily memorized by a
> +human.")
> +    (license license:gpl1)))

According to debian/copyright, included in the upstream tarball, the
license is gpl2.

Can you send an updated patch?

     Thanks!
       Mark

Re: [PATCH] gnu: Add pwgen.

[Steve Sprang]

[-- Attachment #1.1: Type: text/plain, Size: 3728 bytes --]

Sure, here you go.

-Steve

On Wed, Aug 19, 2015 at 12:12 PM, Mark H Weaver <mhw@netris.org> wrote:

> Steve Sprang <steve.sprang@gmail.com> writes:
>
> > From 54acc1b8327291b66120cc83e03b140c242393aa Mon Sep 17 00:00:00 2001
> > From: Steve Sprang <scs@stevesprang.com>
> > Date: Tue, 18 Aug 2015 11:09:03 -0700
> > Subject: [PATCH] gnu: Add pwgen.
> >
> > * gnu/packages/password-utils.scm: New file.
> > * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> > ---
> >  gnu-system.am                   |  1 +
> >  gnu/packages/password-utils.scm | 43
> +++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 44 insertions(+)
> >  create mode 100644 gnu/packages/password-utils.scm
> >
> > diff --git a/gnu-system.am b/gnu-system.am
> > index 9f46f7b..6a086dc 100644
> > --- a/gnu-system.am
> > +++ b/gnu-system.am
> > @@ -239,6 +239,7 @@ GNU_SYSTEM_MODULES =                              \
> >    gnu/packages/ots.scm                               \
> >    gnu/packages/package-management.scm                \
> >    gnu/packages/parallel.scm                  \
> > +  gnu/packages/password-utils.scm            \
> >    gnu/packages/patchutils.scm                        \
> >    gnu/packages/pciutils.scm                  \
> >    gnu/packages/pcre.scm                              \
> > diff --git a/gnu/packages/password-utils.scm
> b/gnu/packages/password-utils.scm
> > new file mode 100644
> > index 0000000..e13495f
> > --- /dev/null
> > +++ b/gnu/packages/password-utils.scm
> > @@ -0,0 +1,43 @@
> > +;;; GNU Guix --- Functional package management for GNU
> > +;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
> > +;;;
> > +;;; This file is part of GNU Guix.
> > +;;;
> > +;;; GNU Guix is free software; you can redistribute it and/or modify it
> > +;;; under the terms of the GNU General Public License as published by
> > +;;; the Free Software Foundation; either version 3 of the License, or
> (at
> > +;;; your option) any later version.
> > +;;;
> > +;;; GNU Guix is distributed in the hope that it will be useful, but
> > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +;;; GNU General Public License for more details.
> > +;;;
> > +;;; You should have received a copy of the GNU General Public License
> > +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> > +
> > +(define-module (gnu packages password-utils)
> > +  #:use-module ((guix licenses) #:prefix license:)
> > +  #:use-module (guix build-system gnu)
> > +  #:use-module (guix download)
> > +  #:use-module (guix packages))
> > +
> > +(define-public pwgen
> > +  (package
> > +    (name "pwgen")
> > +    (version "2.07")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "mirror://sourceforge/pwgen/pwgen-"
> > +                           version ".tar.gz"))
> > +       (sha256
> > +        (base32
> "0mhmw700kkh238fzivcwnwi94bj9f3h36yfh3k3j2v19b0zmjx7b"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:tests? #f))
>
> Please add a comment saying why tests are disabled.  In this case, maybe:
>
>     (arguments
>      `(#:tests? #f))  ; no test suite
>
> > +    (home-page "http://pwgen.sourceforge.net/")
> > +    (synopsis "Password generator")
> > +    (description "Pwgen generates passwords which can be easily
> memorized by a
> > +human.")
> > +    (license license:gpl1)))
>
> According to debian/copyright, included in the upstream tarball, the
> license is gpl2.
>
> Can you send an updated patch?
>
>      Thanks!
>        Mark
>

[-- Attachment #1.2: Type: text/html, Size: 5464 bytes --]

[-- Attachment #2: pwgen2.patch --]
[-- Type: text/x-patch, Size: 2745 bytes --]

From ed063e7f1f16398cd06088a4085c15ea5dbfed08 Mon Sep 17 00:00:00 2001
From: Steve Sprang <scs@stevesprang.com>
Date: Wed, 19 Aug 2015 15:33:04 -0700
Subject: [PATCH] gnu: Add pwgen.

* gnu/packages/password-utils.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                   |  1 +
 gnu/packages/password-utils.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 gnu/packages/password-utils.scm

diff --git a/gnu-system.am b/gnu-system.am
index 147abfc..aca0144 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -239,6 +239,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/ots.scm				\
   gnu/packages/package-management.scm		\
   gnu/packages/parallel.scm			\
+  gnu/packages/password-utils.scm		\
   gnu/packages/patchutils.scm			\
   gnu/packages/pciutils.scm			\
   gnu/packages/pcre.scm				\
diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
new file mode 100644
index 0000000..4aef371
--- /dev/null
+++ b/gnu/packages/password-utils.scm
@@ -0,0 +1,43 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Steve Sprang <scs@stevesprang.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages password-utils)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages))
+
+(define-public pwgen
+  (package
+    (name "pwgen")
+    (version "2.07")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/pwgen/pwgen-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "0mhmw700kkh238fzivcwnwi94bj9f3h36yfh3k3j2v19b0zmjx7b"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f)) ; no test suite
+    (home-page "http://pwgen.sourceforge.net/")
+    (synopsis "Password generator")
+    (description "Pwgen generates passwords which can be easily memorized by a
+human.")
+    (license license:gpl2)))
-- 
2.4.3

Re: [PATCH] gnu: Add pwgen.

[Mark H Weaver]

Steve Sprang <steve.sprang@gmail.com> writes:

> From ed063e7f1f16398cd06088a4085c15ea5dbfed08 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Wed, 19 Aug 2015 15:33:04 -0700
> Subject: [PATCH] gnu: Add pwgen.

Pushed, thanks!

     Mark