From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add ibus-libpinyin.
Date: Wed, 09 Sep 2015 22:07:09 +0200 [thread overview]
Message-ID: <87mvwvs6fm.fsf@gnu.org> (raw)
In-Reply-To: <874mj4azlf.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 09 Sep 2015 08:14:36 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> From 984245dcc1359c4de3ff3a26c0d1d6427a88b6fa Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 9 Sep 2015 07:27:18 +0200
> Subject: [PATCH 1/2] gnu: Add libpinyin.
>
> * gnu/packages/ibus.scm (libpinyin): New variable.
[...]
> + ,(origin
> + (method url-fetch)
> + (uri (string-append "http://downloads.sourceforge.net/libpinyin/"
> + "models/model10.text.tar.gz"))
Should be mirror://sourceforge/ if possible.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("tar" ,tar)
‘tar’ can be omitted, it’s an implicit input.
Otherwise OK.
> From d474729c8f8951e2c7e45cc7dba1b1542ab0e5a8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 9 Sep 2015 07:28:23 +0200
> Subject: [PATCH 2/2] gnu: Add ibus-libpinyin.
>
> * gnu/packages/ibus.scm (ibus-libpinyin): New variable.
LGTM.
It’s a pity that no ‘make dist’ tarball is published; that would make
everbody’s lives easier.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-09-09 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 6:14 [PATCH] Add ibus-libpinyin Ricardo Wurmus
2015-09-09 20:07 ` Ludovic Courtès [this message]
2015-09-12 20:54 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvwvs6fm.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).