From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add ibus-libpinyin.
Date: Wed, 09 Sep 2015 22:07:09 +0200
Message-ID: <87mvwvs6fm.fsf@gnu.org>
References: <874mj4azlf.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZZleG-0006Ek-7e
	for guix-devel@gnu.org; Wed, 09 Sep 2015 16:07:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZZleC-0006ae-VP
	for guix-devel@gnu.org; Wed, 09 Sep 2015 16:07:16 -0400
In-Reply-To: <874mj4azlf.fsf@elephly.net> (Ricardo Wurmus's message of "Wed,
	09 Sep 2015 08:14:36 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 984245dcc1359c4de3ff3a26c0d1d6427a88b6fa Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 9 Sep 2015 07:27:18 +0200
> Subject: [PATCH 1/2] gnu: Add libpinyin.
>
> * gnu/packages/ibus.scm (libpinyin): New variable.

[...]

> +        ,(origin
> +           (method url-fetch)
> +           (uri (string-append "http://downloads.sourceforge.net/libpiny=
in/"
> +                               "models/model10.text.tar.gz"))

Should be mirror://sourceforge/ if possible.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("tar" ,tar)

=E2=80=98tar=E2=80=99 can be omitted, it=E2=80=99s an implicit input.

Otherwise OK.

> From d474729c8f8951e2c7e45cc7dba1b1542ab0e5a8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 9 Sep 2015 07:28:23 +0200
> Subject: [PATCH 2/2] gnu: Add ibus-libpinyin.
>
> * gnu/packages/ibus.scm (ibus-libpinyin): New variable.

LGTM.

It=E2=80=99s a pity that no =E2=80=98make dist=E2=80=99 tarball is publishe=
d; that would make
everbody=E2=80=99s lives easier.

Thanks,
Ludo=E2=80=99.