unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: branch master updated: gnu: ode: Disable tests.
       [not found] <20200124214907.26770.54455@vcs0.savannah.gnu.org>
@ 2020-01-25 14:18 ` Ludovic Courtès
  2020-01-25 18:46   ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-01-25 14:18 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: guix-devel

Hi Nicolas,

guix-commits@gnu.org skribis:

> commit 049bdae52795f01030cb99d6fb271dc4b4ce9a7d
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> AuthorDate: Fri Jan 24 22:47:22 2020 +0100
>
>     gnu: ode: Disable tests.
>     
>     * gnu/packages/game-development.scm (ode): Tests are failing or other systems
>     than x86_64, so we disable them.
> ---
>  gnu/packages/game-development.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> index ee8dea2..72637a7 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -1998,7 +1998,8 @@ a.k.a. XenoCollide) as described in Game Programming Gems 7.")
>             #t))))
>      (build-system cmake-build-system)
>      (arguments
> -     `(#:configure-flags '("-DODE_WITH_LIBCCD_SYSTEM=ON")
> +     `(#:tests? #f                      ;tests fail on all systems but x86_64
> +       #:configure-flags '("-DODE_WITH_LIBCCD_SYSTEM=ON")
>         #:phases

What about disabling tests only on those platforms and (ideally)
reporting a bug upstream about the failures on the other platforms?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: branch master updated: gnu: ode: Disable tests.
  2020-01-25 14:18 ` branch master updated: gnu: ode: Disable tests Ludovic Courtès
@ 2020-01-25 18:46   ` Nicolas Goaziou
  2020-01-28 10:23     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2020-01-25 18:46 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> What about disabling tests only on those platforms 

I didn't realize that was possible. Hopefully, commit
5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this.

> reporting a bug upstream about the failures on the other platforms?

Done here:

  https://bitbucket.org/odedevs/ode/issues/65/tests-failing-on-platforms-other-than

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: branch master updated: gnu: ode: Disable tests.
  2020-01-25 18:46   ` Nicolas Goaziou
@ 2020-01-28 10:23     ` Ludovic Courtès
  2020-01-28 19:27       ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-01-28 10:23 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: guix-devel

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> What about disabling tests only on those platforms 
>
> I didn't realize that was possible. Hopefully, commit
> 5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this.

It does, thanks!  One minor issue:

+     ;; Tests fail on all systems but x86_64.
+     `(#:tests? ,(string=? "x86_64-linux"
+                           (or (%current-target-system)
+                               (%current-system)))

This should rather be:

  (string-prefix? "x86_64-" (or (%current-target-system) (%current-system)))

because ‘%current-target-system’ is a triplet (like “arm-linux-gnueabihf”)
whereas ‘%current-system’ is a “system type” (like “x86_64-linux”).

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: branch master updated: gnu: ode: Disable tests.
  2020-01-28 10:23     ` Ludovic Courtès
@ 2020-01-28 19:27       ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2020-01-28 19:27 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> This should rather be:
>
>   (string-prefix? "x86_64-" (or (%current-target-system) (%current-system)))
>
> because ‘%current-target-system’ is a triplet (like “arm-linux-gnueabihf”)
> whereas ‘%current-system’ is a “system type” (like “x86_64-linux”).

Understood. I fixed it in 07a7cccbac59dd8265fffdd4b87616cd0419a2c7.

Thank you!

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-28 19:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20200124214907.26770.54455@vcs0.savannah.gnu.org>
2020-01-25 14:18 ` branch master updated: gnu: ode: Disable tests Ludovic Courtès
2020-01-25 18:46   ` Nicolas Goaziou
2020-01-28 10:23     ` Ludovic Courtès
2020-01-28 19:27       ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).