From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: branch core-updates-frozen updated: gnu: sddm: Fix build.
Date: Thu, 02 Sep 2021 18:47:10 +0200 [thread overview]
Message-ID: <87mtou53ht.fsf@gnu.org> (raw)
In-Reply-To: <20210902142044.18326.74631@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Thu, 02 Sep 2021 10:20:44 -0400")
Hello!
guix-commits@gnu.org skribis:
> efraim pushed a commit to branch core-updates-frozen
> in repository guix.
>
> The following commit(s) were added to refs/heads/core-updates-frozen by this push:
> new f883677 gnu: sddm: Fix build.
> f883677 is described below
>
> commit f8836774e2c76c1f4d9bee11339839f7d878e32a
> Author: Efraim Flashner <efraim@flashner.co.il>
> AuthorDate: Thu Sep 2 17:15:39 2021 +0300
>
> gnu: sddm: Fix build.
>
> * gnu/packages/display-managers.scm (sddm)[arguments]: Use gexp for
> configure-flags.
Out of curiosity, what was the build issue? Could it be that
‘%build-inputs’ was undefined for this build system?
> (arguments
> `(#:configure-flags
[...]
> + ,#~(list
> + ;; This option currently does nothing, but will presumably be enabled
> + ;; if/when <https://github.com/sddm/sddm/pull/616> is merged.
> + "-DENABLE_WAYLAND=ON"
> + "-DENABLE_PAM=ON"
> + ;; Both flags are required for elogind support.
> + "-DNO_SYSTEMD=ON" "-DUSE_ELOGIND=ON"
> + "-DCONFIG_FILE=/etc/sddm.conf"
> + ;; Set path to /etc/login.defs.
> + ;; An alternative would be to use -DUID_MIN and -DUID_MAX.
> + (string-append "-DLOGIN_DEFS_PATH="
> + #$shadow
Note that this style makes it impossible for users to override “shadow”
via something like:
(package
(inherit sddm)
(inputs `(("shadow" ,my-very-own-shadow))))
To avoid that pitfall, the New Recommended Style™ is:
#~(list …
#$(this-package-input "shadow"))
Thanks,
Ludo’.
next parent reply other threads:[~2021-09-02 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210902142044.18326.74631@vcs0.savannah.gnu.org>
2021-09-02 16:47 ` Ludovic Courtès [this message]
2021-09-02 19:52 ` branch core-updates-frozen updated: gnu: sddm: Fix build Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtou53ht.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).