From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kFpWLWQAMWGmcAAAgWs5BA (envelope-from ) for ; Thu, 02 Sep 2021 18:48:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OI+6KGQAMWG7RwAAB5/wlQ (envelope-from ) for ; Thu, 02 Sep 2021 16:48:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 409DBE00B for ; Thu, 2 Sep 2021 18:48:36 +0200 (CEST) Received: from localhost ([::1]:53088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLptD-00087N-AE for larch@yhetil.org; Thu, 02 Sep 2021 12:48:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLpru-0006w5-HE for guix-devel@gnu.org; Thu, 02 Sep 2021 12:47:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40716) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLprt-0004rt-P3; Thu, 02 Sep 2021 12:47:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48836 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLprt-00005K-FS; Thu, 02 Sep 2021 12:47:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: branch core-updates-frozen updated: gnu: sddm: Fix build. References: <20210902142044.18326.74631@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Fructidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 02 Sep 2021 18:47:10 +0200 In-Reply-To: <20210902142044.18326.74631@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Thu, 02 Sep 2021 10:20:44 -0400") Message-ID: <87mtou53ht.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630601316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Wn5uegKX2wB8QB7OAMizkHdDMj4d/1D61jrpZFXGpu0=; b=V84TFck7lwpz1rE55dxzAwDMLE862GDNcx1EOfHiS6Ed3S8ezQF/O1jUznlwDo78xEnvye Lq5zcjqlmVFZmEEqg53MX+an+neMwTnKx1Lso5hHt6qrW3uLZv1Bzi3nX+sXhl6hwLnE0K fUgA3hQzsJ2uLRJJPjUr+3JPoMSP9i0iih/47ZhsX5U5KLXQ4HnjwKpeZkWZlhrzta2WAs cYLOqpfwsNVoHoM4O8vG+WjAXoWU6bogTK05uIOk9PGFIE565d9C7fQ/yVoALWLnml9OC7 2Sgvzd1R/lX78cDYClerTpCQPB1hTsT/ajWagSyYnv450UNhBHDLMB7won7cJw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630601316; a=rsa-sha256; cv=none; b=OjAAG6NjEaQb8eFEF0aPtr66oKV0Xcb/M33affG/8nB+KRzMVKNX6U44/AlqfUjgg/OeCy sxn7rYLU+dJk1SOE6artuZwoJtX19YCWyIrASZOlaGr0nMS1cn1NWIl6BlTD/nQnHqa/jx ykfYx8nu8mDE7UWyKjb00WdQbACjtSpHHe9nfqJjhswiWxNNeQU6sbBMrHdSsTHGa3Itrh c20P8ZSd0cPw7yEd2d9zqh+EmqdVx2rWRF9Zhs6gxXFyVaQgNqB95bOMQuVgem6plMVIWt hE9gTw3sCpB+QOacMz044zCYX4pDMbukIgCycJ5mblkjz5r5tXi0kcypYWKApg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 409DBE00B X-Spam-Score: -2.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: gjneBZ/tjOw/ Hello! guix-commits@gnu.org skribis: > efraim pushed a commit to branch core-updates-frozen > in repository guix. > > The following commit(s) were added to refs/heads/core-updates-frozen by t= his push: > new f883677 gnu: sddm: Fix build. > f883677 is described below > > commit f8836774e2c76c1f4d9bee11339839f7d878e32a > Author: Efraim Flashner > AuthorDate: Thu Sep 2 17:15:39 2021 +0300 > > gnu: sddm: Fix build. >=20=20=20=20=20 > * gnu/packages/display-managers.scm (sddm)[arguments]: Use gexp for > configure-flags. Out of curiosity, what was the build issue? Could it be that =E2=80=98%build-inputs=E2=80=99 was undefined for this build system? > (arguments > `(#:configure-flags [...] > + ,#~(list > + ;; This option currently does nothing, but will presumably b= e enabled > + ;; if/when is merged. > + "-DENABLE_WAYLAND=3DON" > + "-DENABLE_PAM=3DON" > + ;; Both flags are required for elogind support. > + "-DNO_SYSTEMD=3DON" "-DUSE_ELOGIND=3DON" > + "-DCONFIG_FILE=3D/etc/sddm.conf" > + ;; Set path to /etc/login.defs. > + ;; An alternative would be to use -DUID_MIN and -DUID_MAX. > + (string-append "-DLOGIN_DEFS_PATH=3D" > + #$shadow Note that this style makes it impossible for users to override =E2=80=9Csha= dow=E2=80=9D via something like: (package (inherit sddm) (inputs `(("shadow" ,my-very-own-shadow)))) To avoid that pitfall, the New Recommended Style=E2=84=A2 is: #~(list =E2=80=A6 #$(this-package-input "shadow")) Thanks, Ludo=E2=80=99.