* Re: 02/02: gnu: harfbuzz: Add "bin" output.
[not found] ` <E1ZbpFC-0003g1-5k@vcs.savannah.gnu.org>
@ 2015-09-15 16:23 ` Ludovic Courtès
2015-09-16 0:33 ` 宋文武
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2015-09-15 16:23 UTC (permalink / raw)
To: iyzsong; +Cc: guix-devel
??? <iyzsong@gmail.com> skribis:
> commit eb6afbcde784a72a96f3c5a70d657630d421b02a
> Author: 宋文武 <iyzsong@gmail.com>
> Date: Tue Sep 15 20:19:39 2015 +0800
>
> gnu: harfbuzz: Add "bin" output.
>
> * gnu/packages/gtk.scm (harfbuzz)[outputs]: New field.
> [arguments]<#:configure-flags>: Pass '--bindir'.
[...]
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -154,6 +154,7 @@ affine transformation (scale, rotation, shear, etc.).")
> (base32
> "1xrxlrvgyr6mm9qjxmkif2kvcah082y94gf1vqi0f0bdl1g8gp7b"))))
> (build-system gnu-build-system)
> + (outputs '("out" "bin"))
Could you add a comment explaining why things are split? I suppose this
was motivated by the size of the closure or something, no?
Also, adding an explicit --bindir is normally not necessary: ‘configure’
in gnu-build-system.scm does that when there’s a “bin” output. Or did
it turn out to be buggy?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 02/02: gnu: harfbuzz: Add "bin" output.
2015-09-15 16:23 ` 02/02: gnu: harfbuzz: Add "bin" output Ludovic Courtès
@ 2015-09-16 0:33 ` 宋文武
2015-09-16 20:07 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: 宋文武 @ 2015-09-16 0:33 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: Guix-devel
2015-09-16 0:23 GMT+08:00 Ludovic Courtès <ludo@gnu.org>:
> ??? <iyzsong@gmail.com> skribis:
>
>> commit eb6afbcde784a72a96f3c5a70d657630d421b02a
>> Author: 宋文武 <iyzsong@gmail.com>
>> Date: Tue Sep 15 20:19:39 2015 +0800
>>
>> gnu: harfbuzz: Add "bin" output.
>>
>> * gnu/packages/gtk.scm (harfbuzz)[outputs]: New field.
>> [arguments]<#:configure-flags>: Pass '--bindir'.
>
> [...]
>
>> --- a/gnu/packages/gtk.scm
>> +++ b/gnu/packages/gtk.scm
>> @@ -154,6 +154,7 @@ affine transformation (scale, rotation, shear, etc.).")
>> (base32
>> "1xrxlrvgyr6mm9qjxmkif2kvcah082y94gf1vqi0f0bdl1g8gp7b"))))
>> (build-system gnu-build-system)
>> + (outputs '("out" "bin"))
>
> Could you add a comment explaining why things are split? I suppose this
> was motivated by the size of the closure or something, no?
Yes, I notice only the executables depend on cairo, and is about 100k of 700kb.
>
> Also, adding an explicit --bindir is normally not necessary: ‘configure’
> in gnu-build-system.scm does that when there’s a “bin” output. Or did
> it turn out to be buggy?
oops, I don't know this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 02/02: gnu: harfbuzz: Add "bin" output.
2015-09-16 0:33 ` 宋文武
@ 2015-09-16 20:07 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2015-09-16 20:07 UTC (permalink / raw)
To: 宋文武; +Cc: Guix-devel
宋文武 <iyzsong@gmail.com> skribis:
> 2015-09-16 0:23 GMT+08:00 Ludovic Courtès <ludo@gnu.org>:
>> ??? <iyzsong@gmail.com> skribis:
>>
>>> commit eb6afbcde784a72a96f3c5a70d657630d421b02a
>>> Author: 宋文武 <iyzsong@gmail.com>
>>> Date: Tue Sep 15 20:19:39 2015 +0800
>>>
>>> gnu: harfbuzz: Add "bin" output.
>>>
>>> * gnu/packages/gtk.scm (harfbuzz)[outputs]: New field.
>>> [arguments]<#:configure-flags>: Pass '--bindir'.
>>
>> [...]
>>
>>> --- a/gnu/packages/gtk.scm
>>> +++ b/gnu/packages/gtk.scm
>>> @@ -154,6 +154,7 @@ affine transformation (scale, rotation, shear, etc.).")
>>> (base32
>>> "1xrxlrvgyr6mm9qjxmkif2kvcah082y94gf1vqi0f0bdl1g8gp7b"))))
>>> (build-system gnu-build-system)
>>> + (outputs '("out" "bin"))
>>
>> Could you add a comment explaining why things are split? I suppose this
>> was motivated by the size of the closure or something, no?
> Yes, I notice only the executables depend on cairo, and is about 100k of 700kb.
OK, makes sense. Could you make this a comment next to the ‘outputs’
field?
>> Also, adding an explicit --bindir is normally not necessary: ‘configure’
>> in gnu-build-system.scm does that when there’s a “bin” output. Or did
>> it turn out to be buggy?
> oops, I don't know this.
No problem!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-16 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20150915122151.14062.15456@vcs.savannah.gnu.org>
[not found] ` <E1ZbpFC-0003g1-5k@vcs.savannah.gnu.org>
2015-09-15 16:23 ` 02/02: gnu: harfbuzz: Add "bin" output Ludovic Courtès
2015-09-16 0:33 ` 宋文武
2015-09-16 20:07 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).