Add GNUMach Headers

Add GNUMach Headers

[ΜΑΝΩΛΗΣ ΡΑΓΚΟΥΣΗΣ]

[-- Attachment #1.1: Type: text/plain, Size: 294 bytes --]

The recipe for gnumach header files. Mig  and gnumach kernel patches coming
as soon as possible.
In order to build it in a 64 bit machine you have to use
"--system=i686-linux"

It's my first patch ,so please don't yell at me if I did something wrong :-)

Cheers,

Manolis 'phant0mas' Ragkousis

[-- Attachment #1.2: Type: text/html, Size: 413 bytes --]

[-- Attachment #2: 0001_gnu_Add_gnumach_headers --]
[-- Type: application/octet-stream, Size: 2962 bytes --]

From ff3ee75b23e33b0250ce64ba90969d2a8ad4c521 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Sat, 15 Feb 2014 22:05:29 +0000
Subject: [PATCH] Add GNU Mach kernel headers

---
 gnu-system.am         |  1 +
 gnu/packages/hurd.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 gnu/packages/hurd.scm

diff --git a/gnu-system.am b/gnu-system.am
index 8229cf0..7e68290 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -105,6 +105,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/gxmessage.scm			\
   gnu/packages/help2man.scm			\
   gnu/packages/hugs.scm				\
+  gnu/packages/hurd.scm				\
   gnu/packages/icu4c.scm			\
   gnu/packages/idutils.scm			\
   gnu/packages/imagemagick.scm			\
diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
new file mode 100644
index 0000000..0a6a9bc
--- /dev/null
+++ b/gnu/packages/hurd.scm
@@ -0,0 +1,54 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+
+(define-module (gnu packages hurd)
+  #:use-module (guix licenses)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu))
+
+
+(define-public gnumach-headers
+  (package
+    (name "gnumach-headers")
+    (version "1.4")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://ftp.gnu.org.ua/gnu/gnumach/gnumach-"
+                          version ".tar.gz"))
+      (sha256
+       (base32
+        "0r371wsm7imx356p0xsls5hifb1gf9y90rm1phr0qkahbmfk9hlv"))))
+    (build-system gnu-build-system)
+    (arguments 
+     `( #:phases (alist-replace
+                  'install 
+                  (lambda _ (zero?
+                             (system* "make" "install-data")))
+                  (alist-delete
+                   'build
+                   %standard-phases))              
+        #:tests? #f ))
+    (home-page "https://www.gnu.org/software/hurd/microkernel/mach/gnumach.html")
+    (synopsis "GNU Mach kernel headers")
+    (description
+     "Headers of the GNU Mach kernel.")
+    (license gpl2+)))
+;;TODO: package the rest of the components of the GNU Hurd system
-- 
1.8.5.3

Re: Add GNUMach Headers

[ΜΑΝΩΛΗΣ ΡΑΓΚΟΥΣΗΣ]

[-- Attachment #1.1: Type: text/plain, Size: 481 bytes --]

Something went wrong with the file,I am very sorry
Here is the right one!



2014-02-15 20:45 GMT+00:00 ΜΑΝΩΛΗΣ ΡΑΓΚΟΥΣΗΣ <manolis837@gmail.com>:

> The recipe for gnumach header files. Mig  and gnumach kernel patches
> coming as soon as possible.
> In order to build it in a 64 bit machine you have to use
> "--system=i686-linux"
>
> It's my first patch ,so please don't yell at me if I did something wrong
> :-)
>
> Cheers,
>
> Manolis 'phant0mas' Ragkousis
>

[-- Attachment #1.2: Type: text/html, Size: 894 bytes --]

[-- Attachment #2: 0001_gnu_Add_gnumach_headers.patch --]
[-- Type: text/x-patch, Size: 2962 bytes --]

From ff3ee75b23e33b0250ce64ba90969d2a8ad4c521 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Sat, 15 Feb 2014 22:05:29 +0000
Subject: [PATCH] Add GNU Mach kernel headers

---
 gnu-system.am         |  1 +
 gnu/packages/hurd.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 gnu/packages/hurd.scm

diff --git a/gnu-system.am b/gnu-system.am
index 8229cf0..7e68290 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -105,6 +105,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/gxmessage.scm			\
   gnu/packages/help2man.scm			\
   gnu/packages/hugs.scm				\
+  gnu/packages/hurd.scm				\
   gnu/packages/icu4c.scm			\
   gnu/packages/idutils.scm			\
   gnu/packages/imagemagick.scm			\
diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
new file mode 100644
index 0000000..0a6a9bc
--- /dev/null
+++ b/gnu/packages/hurd.scm
@@ -0,0 +1,54 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+
+(define-module (gnu packages hurd)
+  #:use-module (guix licenses)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu))
+
+
+(define-public gnumach-headers
+  (package
+    (name "gnumach-headers")
+    (version "1.4")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://ftp.gnu.org.ua/gnu/gnumach/gnumach-"
+                          version ".tar.gz"))
+      (sha256
+       (base32
+        "0r371wsm7imx356p0xsls5hifb1gf9y90rm1phr0qkahbmfk9hlv"))))
+    (build-system gnu-build-system)
+    (arguments 
+     `( #:phases (alist-replace
+                  'install 
+                  (lambda _ (zero?
+                             (system* "make" "install-data")))
+                  (alist-delete
+                   'build
+                   %standard-phases))              
+        #:tests? #f ))
+    (home-page "https://www.gnu.org/software/hurd/microkernel/mach/gnumach.html")
+    (synopsis "GNU Mach kernel headers")
+    (description
+     "Headers of the GNU Mach kernel.")
+    (license gpl2+)))
+;;TODO: package the rest of the components of the GNU Hurd system
-- 
1.8.5.3

Re: Add GNUMach Headers

[Ludovic Courtès]

Hello!

Thanks for the patch, and welcome!

This looks good to me, but as a welcome present ;-), I’ll do some
nitpicking so you can learn about the conventions in use.

ΜΑΝΩΛΗΣ ΡΑΓΚΟΥΣΗΣ <manolis837@gmail.com> skribis:

> From ff3ee75b23e33b0250ce64ba90969d2a8ad4c521 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 15 Feb 2014 22:05:29 +0000
> Subject: [PATCH] Add GNU Mach kernel headers
>
> ---
>  gnu-system.am         |  1 +
>  gnu/packages/hurd.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++

Please add a ChangeLog-style commit log entry (see the ‘HACKING’ file
for details.)

Also, we usually prefix with ‘gnu: ’ the subject line when changing
something under the gnu/ directory.

In general, see ‘git log’ when in doubt.  :-)

> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "http://ftp.gnu.org.ua/gnu/gnumach/gnumach-"
> +                          version ".tar.gz"))

This should be “mirror://gnu/gnumach/...” to allow the use of gnu.org
mirrors.

> +    (arguments 
> +     `( #:phases (alist-replace
          ^
There should be no space here.

> +                  'install 
> +                  (lambda _ (zero?
> +                             (system* "make" "install-data")))

Rather:

  (lambda _ ;; <- always skip a line after the lambda argument list
    (zero? ...))

> +                  (alist-delete
> +                   'build
> +                   %standard-phases))              
> +        #:tests? #f ))
                      ^
No space here.

> +;;TODO: package the rest of the components of the GNU Hurd system

No need to put it here, this is implicit.  :-)

Could you send an updated patch?

Thanks for diving into this!

Ludo’.

Re: Add GNUMach Headers

[Ludovic Courtès]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> Updated patch ,I hoped I did everything right this time :-)

You did, except for one thing: I added --build=i686-pc-gnu so that
‘configure’ always passes.

> From 5bb466e5c3c881115816399d5d6e49795e271e50 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sun, 16 Feb 2014 10:17:52 +0000
> Subject: [PATCH] gnu: Add GNUMach headers
>
> * gnu/packages/hurd.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add hurd.scm

Pushed, thank you!

Ludo’.