[PATCH 1/3] gnu: Add python-feedgenerator

[PATCH 1/3] gnu: Add python-feedgenerator

[Christopher Allan Webber]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Hello!  I'm packaging pelican, so here's the first of the couple of
required dependencies to install it.

(Unfortunately we have to install from git because the LICENSE file was
just added at my request.  Otherwise I'd use a tarball!)


[-- Attachment #2: 0001-gnu-Add-python-feedgenerator.patch --]
[-- Type: text/x-diff, Size: 2719 bytes --]

From 32fe80103c1cef93f1608d5c09e4edf7cd005a5e Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 10 Jul 2015 15:49:07 -0500
Subject: [PATCH 1/3] gnu: Add python-feedgenerator

* gnu/packages/python.scm (python-feedgenerator, python2-feedgenerator): New variables.
---
 gnu/packages/python.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5dcaba0..7d77da0 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com>
 ;;; Copyright © 2015 Pierre-Antoine Rault <par@rigelk.eu>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2066,6 +2067,44 @@ sources.")
 (define-public python2-sphinx-rtd-theme
   (package-with-python2 python-sphinx-rtd-theme))
 
+(define-public python-feedgenerator
+  (package
+    (name "python-feedgenerator")
+    (version "20150710.97185b7")
+    (source
+     ;; Using the git checkout for now because license file not added till
+     ;; https://github.com/dmdm/feedgenerator-py3k/commit/97185b7566c240c4bf5ed80db7d6c271204dab39
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/dmdm/feedgenerator-py3k.git")
+             (commit "97185b7566c240c4bf5ed80db7d6c271204dab39")))
+       (sha256
+        (base32
+         "0dbd6apij5j1923ib905x0srgcyls4wlabqlwp4dzkwmksvnrr2a"))))
+    (arguments
+     ;; incompatible with Python 3 (exception syntax)
+     `(;; With standard flags, the install phase attempts to create a zip'd
+       ;; egg file, and fails with an error: 'ZIP does not support timestamps
+       ;; before 1980'
+       #:configure-flags '("--single-version-externally-managed"
+                           "--record=feedgenerator.txt")))
+    (build-system python-build-system)
+    (inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-pytz" ,python-pytz)
+       ("python-six" ,python-six)))
+    (home-page
+     "https://github.com/dmdm/feedgenerator-py3k.git")
+    (synopsis
+     "Standalone version of django.utils.feedgenerator, compatible with Py3k")
+    (description
+     "Feedgenerator-py3k is a standalone version of Django's feedgenerator.")
+    (license bsd-3)))
+
+(define-public python2-feedgenerator
+  (package-with-python2 python-feedgenerator))
+
 (define-public python-scikit-learn
   (package
     (name "python-scikit-learn")
-- 
2.1.4

Re: [PATCH 1/3] gnu: Add python-feedgenerator

[Ludovic Courtès]

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> From 32fe80103c1cef93f1608d5c09e4edf7cd005a5e Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 10 Jul 2015 15:49:07 -0500
> Subject: [PATCH 1/3] gnu: Add python-feedgenerator
>
> * gnu/packages/python.scm (python-feedgenerator, python2-feedgenerator): New variables.

[...]

> +    (arguments
> +     ;; incompatible with Python 3 (exception syntax)

I think this comment is a leftover, no?

> +    (synopsis
> +     "Standalone version of django.utils.feedgenerator, compatible with Py3k")

Maybe something like: “Standalone version of Django's RSS feed generator”?

> +    (description
> +     "Feedgenerator-py3k is a standalone version of Django's feedgenerator.")

s/\./, which can produce feeds in RSS 2.0, Atom, and Foobar formats./

OK with changes along these lines!

Ludo’.

Re: [PATCH 1/3] gnu: Add python-feedgenerator

[Christopher Allan Webber]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Ludovic Courtès writes:

> Christopher Allan Webber <cwebber@dustycloud.org> skribis:
>
>> From 32fe80103c1cef93f1608d5c09e4edf7cd005a5e Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>> Date: Fri, 10 Jul 2015 15:49:07 -0500
>> Subject: [PATCH 1/3] gnu: Add python-feedgenerator
>>
>> * gnu/packages/python.scm (python-feedgenerator, python2-feedgenerator): New variables.
>
> [...]
>
>> +    (arguments
>> +     ;; incompatible with Python 3 (exception syntax)
>
> I think this comment is a leftover, no?
>
>> +    (synopsis
>> +     "Standalone version of django.utils.feedgenerator, compatible with Py3k")
>
> Maybe something like: “Standalone version of Django's RSS feed generator”?
>
>> +    (description
>> +     "Feedgenerator-py3k is a standalone version of Django's feedgenerator.")
>
> s/\./, which can produce feeds in RSS 2.0, Atom, and Foobar formats./
>
> OK with changes along these lines!
>
> Ludo’.

Great!  All good catches.  Here's an updated version of the patch!


[-- Attachment #2: 0001-gnu-Add-python-feedgenerator.patch --]
[-- Type: text/x-diff, Size: 2713 bytes --]

From 0967b42f2f7c46922d801e221737dd4559069944 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 10 Jul 2015 15:49:07 -0500
Subject: [PATCH 1/3] gnu: Add python-feedgenerator

* gnu/packages/python.scm (python-feedgenerator, python2-feedgenerator): New variables.
---
 gnu/packages/python.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5dcaba0..690e390 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com>
 ;;; Copyright © 2015 Pierre-Antoine Rault <par@rigelk.eu>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2066,6 +2067,44 @@ sources.")
 (define-public python2-sphinx-rtd-theme
   (package-with-python2 python-sphinx-rtd-theme))
 
+(define-public python-feedgenerator
+  (package
+    (name "python-feedgenerator")
+    (version "20150710.97185b7")
+    (source
+     ;; Using the git checkout for now because license file not added till
+     ;; https://github.com/dmdm/feedgenerator-py3k/commit/97185b7566c240c4bf5ed80db7d6c271204dab39
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/dmdm/feedgenerator-py3k.git")
+             (commit "97185b7566c240c4bf5ed80db7d6c271204dab39")))
+       (sha256
+        (base32
+         "0dbd6apij5j1923ib905x0srgcyls4wlabqlwp4dzkwmksvnrr2a"))))
+    (arguments
+     `(;; With standard flags, the install phase attempts to create a zip'd
+       ;; egg file, and fails with an error: 'ZIP does not support timestamps
+       ;; before 1980'
+       #:configure-flags '("--single-version-externally-managed"
+                           "--record=feedgenerator.txt")))
+    (build-system python-build-system)
+    (inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-pytz" ,python-pytz)
+       ("python-six" ,python-six)))
+    (home-page
+     "https://github.com/dmdm/feedgenerator-py3k.git")
+    (synopsis
+     "Standalone version of Django's Atom/RSS feed generator")
+    (description
+     "Feedgenerator-py3k is a standalone version of Django's feedgenerator,
+which can produce feeds in RSS 2.0, RSS 0.91, and Atom formats.")
+    (license bsd-3)))
+
+(define-public python2-feedgenerator
+  (package-with-python2 python-feedgenerator))
+
 (define-public python-scikit-learn
   (package
     (name "python-scikit-learn")
-- 
2.1.4

Re: [PATCH 1/3] gnu: Add python-feedgenerator

[Ludovic Courtès]

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> From 0967b42f2f7c46922d801e221737dd4559069944 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 10 Jul 2015 15:49:07 -0500
> Subject: [PATCH 1/3] gnu: Add python-feedgenerator
>
> * gnu/packages/python.scm (python-feedgenerator, python2-feedgenerator): New variables.

Applied, thanks!

Ludo’.