Re: 01/01: gnu: solfege: Make configuration more robust to GC

Re: 01/01: gnu: solfege: Make configuration more robust to GC

[Mark H Weaver]

Hi Nicolas,

mail@nicolasgoaziou.fr (Nicolas Goaziou) writes:

> ngz pushed a commit to branch master
> in repository guix.
>
> commit 95e545a4dafe82499c68625e0c145df45ac38484
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date:   Thu Feb 1 22:38:42 2018 +0100
>
>     gnu: solfege: Make configuration more robust to GC

Did you test this?  It failed with the following error:

--8<---------------cut here---------------start------------->8---
@ build-started /gnu/store/6x7md71bdd2lwyrvcfsxs7s4z91ilraf-solfege-3.22.2.drv - x86_64-linux /var/log/guix/drvs/6x//7md71bdd2lwyrvcfsxs7s4z91ilraf-solfege-3.22.2.drv.bz2
ice-9/boot-9.scm:222:17: In procedure map1:
Syntax error:
/gnu/store/9bmqpvnrmkqygdgnncrjllqj35f0wdg5-solfege-3.22.2-guile-builder:2:3952: let: bad let in form (let (("aplay" (match:substring m 0))) (let-matches (+ 1 0) m () (loop rest (match:end m) (cons* (begin) (substring l o (match:start m)) r))))
builder for `/gnu/store/6x7md71bdd2lwyrvcfsxs7s4z91ilraf-solfege-3.22.2.drv' failed with exit code 1
@ build-failed /gnu/store/6x7md71bdd2lwyrvcfsxs7s4z91ilraf-solfege-3.22.2.drv - 1 builder for `/gnu/store/6x7md71bdd2lwyrvcfsxs7s4z91ilraf-solfege-3.22.2.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

and the problem is a syntax error, here:

> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2fb62d0..2e8bc17 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -10,7 +10,7 @@
>  ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
>  ;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
>  ;;; Copyright © 2017 Rodger Fox <thylakoid@openmailbox.org>
> -;;; Copyright © 2017 Nicolas Goaziou <mail@nicolasgoaziou.fr>
> +;;; Copyright © 2017, 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
>  ;;; Copyright © 2017 Pierre Langlois <pierre.langlois@gmx.com>
>  ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
>  ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
> @@ -1050,22 +1050,10 @@ complete studio.")
>           (add-after 'unpack 'fix-configuration
>             (lambda* (#:key inputs #:allow-other-keys)
>               (substitute* "default.config"
> -               (("csound=csound")
> -                (string-append "csound="
> -                               (assoc-ref inputs "csound")
> -                               "/bin/csound"))
> -               (("/usr/bin/aplay")
> -                (string-append (assoc-ref inputs "aplay")
> -                               "/bin/aplay"))
> -               (("/usr/bin/timidity")
> -                (string-append (assoc-ref inputs "timidity")
> -                               "/bin/timidity"))
> -               (("/usr/bin/mpg123")
> -                (string-append (assoc-ref inputs "mpg123")
> -                               "/bin/mpg123"))
> -               (("/usr/bin/ogg123")
> -                (string-append (assoc-ref inputs "ogg123")
> -                               "/bin/ogg123")))
> +               (("/usr/bin/aplay" "aplay"))

In the line above, one of the right parentheses is misplaced.  It should
be like this:

> +               (("/usr/bin/aplay") "aplay")

I guess that maybe you made some changes after your last test?
Can you fix it please?

       Mark

Re: 01/01: gnu: solfege: Make configuration more robust to GC

[Nicolas Goaziou]

Hello,

Mark H Weaver <mhw@netris.org> writes:

>> +               (("/usr/bin/aplay" "aplay"))
>
> In the line above, one of the right parentheses is misplaced.  It should
> be like this:
>
>> +               (("/usr/bin/aplay") "aplay")
>
> I guess that maybe you made some changes after your last test?
> Can you fix it please?

Fixed. Thank you!

Regards,

-- 
Nicolas Goaziou                                                0x80A93738