Re: 25/65: gnu: Add sbcl-slime-swank.

Re: 25/65: gnu: Add sbcl-slime-swank.

[Ludovic Courtès]

Hi Pierre,

mail@ambrevar.xyz (Pierre Neidhardt) skribis:

> commit c4d4ae1e16254a96caaeb5ccb4486f301ae4f1b7
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Tue Sep 11 22:59:35 2018 +0200
>
>     gnu: Add sbcl-slime-swank.
>     
>     * gnu/packages/lisp.scm (sbcl-slime-swank): New variable.

[...]

> +       (method git-fetch)
> +       (uri (git-reference
> +             ;; (url "https://github.com/slime/slime/")
> +             ;; (commit "841f61467c03dea9f38ff9d5af0e21a8aa29e8f7")
> +             ;; REVIEW: Do we need sionescu's patch to package SWANK?
> +             (url "https://github.com/sionescu/slime/")
> +             ;; (commit "swank-asdf")
> +             (commit "2f7c3fcb3ac7d50d844d5c6ca0e89b52a45e1d3a")))

Leftovers?  :-)

> +    (license (license (list license:gpl2+ license:public-domain)))))

For the record this typo made it impossible to build Guix (“license:
unbound variable”).  This was easily fixed in
0ee6692a63538e874ba0b4d85584a4a73b75367c so no big deal, though make
sure to run “make” before “git push” next time.

Thank you for all the Common Lisp packages!

Ludo’.

Re: 25/65: gnu: Add sbcl-slime-swank.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

> Leftovers?  :-)

No, I kept this on purpose because sionescu's fork is not official and the issue
is still open upstream.  
It would be nice at some point to switch back to the official repo.

> For the record this typo made it impossible to build Guix (“license:
> unbound variable”).  This was easily fixed in
> 0ee6692a63538e874ba0b4d85584a4a73b75367c so no big deal, though make
> sure to run “make” before “git push” next time.

Oopsy, very sorry about this!
Lesson learned, I'll make sure to build before pushing from now on.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 25/65: gnu: Add sbcl-slime-swank.

[Ludovic Courtès]

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

>> Leftovers?  :-)
>
> No, I kept this on purpose because sionescu's fork is not official and the issue
> is still open upstream.  
> It would be nice at some point to switch back to the official repo.

Oh I see, I hadn’t understood that.

>> For the record this typo made it impossible to build Guix (“license:
>> unbound variable”).  This was easily fixed in
>> 0ee6692a63538e874ba0b4d85584a4a73b75367c so no big deal, though make
>> sure to run “make” before “git push” next time.
>
> Oopsy, very sorry about this!
> Lesson learned, I'll make sure to build before pushing from now on.

OK!  :-)

Ludo’.