From: Kyle Meyer <kyle@kyleam.com>
To: Brett Gilio <brettg@posteo.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Magit is painfully slow
Date: Sat, 29 Dec 2018 15:27:13 -0500 [thread overview]
Message-ID: <87k1jsuli6.fsf@kyleam.com> (raw)
In-Reply-To: <87wons5glg.fsf@posteo.net>
Brett Gilio <brettg@posteo.net> writes:
> Kyle Meyer writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
[...]
>>> That’s because it’s trying to colorize the diff of thousands of lines of
>>> .po and .texi changes.
>>
>> With the default settings and no cached visibility for the repo, the
>> hunks should not be expanded, so Magit isn't actually coloring/painting
>> them yet. In this case, the processing of these diffs will be slow
>> regardless of whether they are painted and the CLI "git checkout"
>> suggestion is good, but I think the delayed painting is worth noting
>> because users may not realize that their custom visibility settings are
>> making things slower.
[...]
> Kyle,
> What do you suggest here?
Sorry for not being clear. I agree with Ricardo's suggestion and wasn't
offering another one. I was pointing out that, with the default
configuration, the lag is due to diff processing *other than colorizing*
because Magit delays painting hidden diffs. Based on how the user
configures section visibility (e.g., via
magit-section-initial-visibility-alist and
magit-section-cache-visibility), the diffs may not be hidden, leading to
additional time spent painting the diffs.
prev parent reply other threads:[~2018-12-29 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 7:08 Magit is painfully slow Brett Gilio
2018-12-29 8:17 ` Ricardo Wurmus
2018-12-29 16:44 ` Kyle Meyer
2018-12-29 18:32 ` Brett Gilio
2018-12-29 20:27 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1jsuli6.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=brettg@posteo.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).