From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: Magit is painfully slow Date: Sat, 29 Dec 2018 15:27:13 -0500 Message-ID: <87k1jsuli6.fsf@kyleam.com> References: <87d0pkbyjo.fsf@posteo.net> <8736qg4uhb.fsf@elephly.net> <8736qg9tba.fsf@kyleam.com> <87wons5glg.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:54044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdLD2-0003nz-E2 for guix-devel@gnu.org; Sat, 29 Dec 2018 15:27:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdLCX-0007Qy-Tj for guix-devel@gnu.org; Sat, 29 Dec 2018 15:27:21 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gdLCX-0007PE-0q for guix-devel@gnu.org; Sat, 29 Dec 2018 15:27:17 -0500 In-Reply-To: <87wons5glg.fsf@posteo.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Brett Gilio Cc: guix-devel Brett Gilio writes: > Kyle Meyer writes: > >> Ricardo Wurmus writes: [...] >>> That=E2=80=99s because it=E2=80=99s trying to colorize the diff of thou= sands of lines of >>> .po and .texi changes. >> >> With the default settings and no cached visibility for the repo, the >> hunks should not be expanded, so Magit isn't actually coloring/painting >> them yet. In this case, the processing of these diffs will be slow >> regardless of whether they are painted and the CLI "git checkout" >> suggestion is good, but I think the delayed painting is worth noting >> because users may not realize that their custom visibility settings are >> making things slower. [...] > Kyle, > What do you suggest here? Sorry for not being clear. I agree with Ricardo's suggestion and wasn't offering another one. I was pointing out that, with the default configuration, the lag is due to diff processing *other than colorizing* because Magit delays painting hidden diffs. Based on how the user configures section visibility (e.g., via magit-section-initial-visibility-alist and magit-section-cache-visibility), the diffs may not be hidden, leading to additional time spent painting the diffs.