* Patch xdg-open in emacs-embark package
@ 2023-05-10 2:11 jgart
2023-05-10 11:23 ` Mekeor Melire
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: jgart @ 2023-05-10 2:11 UTC (permalink / raw)
To: guix-devel
Just writing down a public TODO for myself:
TODO: patch xdg-open (xdg-utils) in emacs-embark package.
https://github.com/oantolin/embark/blob/f88314044d5492efeacb9466122889c6e60c8af4/embark.el#L3710
If anyone else wants to work on this feel free to.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch xdg-open in emacs-embark package
2023-05-10 2:11 Patch xdg-open in emacs-embark package jgart
@ 2023-05-10 11:23 ` Mekeor Melire
2023-05-10 17:34 ` jgart
2023-05-10 17:40 ` jgart
2 siblings, 0 replies; 5+ messages in thread
From: Mekeor Melire @ 2023-05-10 11:23 UTC (permalink / raw)
To: jgart; +Cc: guix-devel
2023-05-10 02:11 jgart@dismail.de:
> Just writing down a public TODO for myself:
>
> TODO: patch xdg-open (xdg-utils) in emacs-embark package.
>
> https://github.com/oantolin/embark/blob/f88314044d5492efeacb9466122889c6e60c8af4/embark.el#L3710
>
> If anyone else wants to work on this feel free to.
We could introduce a defcustom variable for this command,
upstream, so that we can use `emacs-substitute-variables'[1]
within the package declaration in the Guix repository. WDYT?
[1]
https://github.com/guix-mirror/guix/blob/d1aba42ad4e1909faa21d484975c5954c778e002/guix/build/emacs-utils.scm#L211
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch xdg-open in emacs-embark package
2023-05-10 2:11 Patch xdg-open in emacs-embark package jgart
2023-05-10 11:23 ` Mekeor Melire
@ 2023-05-10 17:34 ` jgart
2023-05-10 17:40 ` jgart
2 siblings, 0 replies; 5+ messages in thread
From: jgart @ 2023-05-10 17:34 UTC (permalink / raw)
To: Mekeor Melire; +Cc: guix-devel
Hi,
Yes, definitely please do open a PR upstream for that.
Sounds good to me.
Keep us posted here on the thread on that status of that.
all best,
jgart
May 10, 2023 6:29 AM, "Mekeor Melire" <mekeor@posteo.de> wrote:
> 2023-05-10 02:11 jgart@dismail.de:
>
>> Just writing down a public TODO for myself:
>>
>> TODO: patch xdg-open (xdg-utils) in emacs-embark package.
>>
>> https://github.com/oantolin/embark/blob/f88314044d5492efeacb9466122889c6e60c8af4/embark.el#L3710
>>
>> If anyone else wants to work on this feel free to.
>
> We could introduce a defcustom variable for this command, upstream, so that we can use
> `emacs-substitute-variables'[1] within the package declaration in the Guix repository. WDYT?
>
> [1]
> https://github.com/guix-mirror/guix/blob/d1aba42ad4e1909faa21d484975c5954c778e002/guix/build/emacs-u
> ils.scm#L211
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch xdg-open in emacs-embark package
2023-05-10 2:11 Patch xdg-open in emacs-embark package jgart
2023-05-10 11:23 ` Mekeor Melire
2023-05-10 17:34 ` jgart
@ 2023-05-10 17:40 ` jgart
2023-05-21 19:34 ` Mekeor Melire
2 siblings, 1 reply; 5+ messages in thread
From: jgart @ 2023-05-10 17:40 UTC (permalink / raw)
To: Mekeor Melire; +Cc: guix-devel
BTW,
I discovered this because when I tried calling that function in eshell (with eat-eshell-mode enabled, btw lol) it complained that xdg-open was not install.
;()
Just a little story about the discovery.
I think it would be great to not worry about installing xdg-open if you install emacs-embark and it depends on it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch xdg-open in emacs-embark package
2023-05-10 17:40 ` jgart
@ 2023-05-21 19:34 ` Mekeor Melire
0 siblings, 0 replies; 5+ messages in thread
From: Mekeor Melire @ 2023-05-21 19:34 UTC (permalink / raw)
To: jgart; +Cc: guix-devel
2023-05-10 17:40 jgart@dismail.de:
> I think it would be great to not worry about installing xdg-open
> if you install emacs-embark and it depends on it.
I'm not sure about this since embark.el does a lot more than
invoking xdg-open and also, it can be used without xdg-open, while
still being useful.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-21 19:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 2:11 Patch xdg-open in emacs-embark package jgart
2023-05-10 11:23 ` Mekeor Melire
2023-05-10 17:34 ` jgart
2023-05-10 17:40 ` jgart
2023-05-21 19:34 ` Mekeor Melire
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).