Re: [PATCH 2/2] gnu: gnunet: Add gnunet-0.10.0.

[ludo@gnu.org (Ludovic Courtès)]

Sree Harsha Totakura <sreeharsha@totakura.in> skribis:

> * gnunet/packages/gnunet.scm (gnunet): New variable.  Thanks to Zerwas for the initial recipe.
> * gnu/package/patches/gnunet-fix-scheduler.patch: Patch to fix bug in Gnunet's scheduler.
> * gnu/package/patches/gnunet-fix-tests.patch: Patch to fix bugs in testcases and to disable testscases which rely on name resolution.
> * gnu-system.am (dist_patch_DATA): Add the above two patch files.

Excellent!

Can you wrap lines to ~75 chars?  Also, you can use ‘Co-authored-by:
Zerwas’ if deemed appropriate here.

s/Gnunet/GNUnet/

The .patch files above should just have “New files” in the commit log
(see other commits for examples.)  However, can you please move the
description of what the patches do at the top of the patches themselves,
possibly with a reference to the upstream commit/bug report/discussion?

> +   (arguments
> +    '(#:phases
> +      (let* ((check (assq 'check %standard-phases))
> +             (alist (delete check %standard-phases))
> +             (testsetup
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let ((out (assoc-ref outputs "out")))
> +                  (setenv "GNUNET_PREFIX" out)
> +                  (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))
> +                  #t))))
> +        (display %standard-phases)
> +        (alist-cons-after 'testsetup (car check) (cdr check)
> +                          (alist-cons-after 'install 'testsetup testsetup
> +                                            alist)))))

I think the ‘display’ is a leftover, right?  ;-)

I would rather write it this way:

  (let* ((check (assq-ref %standard-phases 'check))
         (pre-check
           (lambda* ...)))
    (alist-cons-after 'pre-check 'check check
                      (alist-cons-after 'install 'pre-check pre-check
                                        (alist-delete 'check
                                                       %standard-phases))))

(Woow, this ought to be simpler...)

> +   (synopsis "Secure P2P networking framework with cool applications")
> +   (description
> +    "GNUnet is a framework for secure peer-to-peer networking that does not
> +use any centralized or otherwise trusted services. Our high-level goal is to
> +provide a strong free software foundation for a global network that provides
> +security and in particular respects privacy.  GNUnet started with an idea for
> +anonymous censorship-resistant file-sharing, but has grown to incorporate
> +other applications as well as many generic building blocks for secure
> +networking applications. In particular, GNUnet now includes the GNU Name
> +System, a privacy-preserving, decentralized public key infrastructure")

Could you run ‘make sync-descriptions’ and use whatever synopsis and
description it suggests?  (That comes from the canonical GNU package
database.)

Thanks for the nice work!

Ludo’.