From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] gnu: gnunet: Add gnunet-0.10.0. Date: Thu, 30 Jan 2014 22:11:10 +0100 Message-ID: <87ha8lb2fl.fsf@gnu.org> References: <52EA7F73.9010302@totakura.in> <1391099831-14896-1-git-send-email-sreeharsha@totakura.in> <1391099831-14896-2-git-send-email-sreeharsha@totakura.in> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8yyB-0004tD-Pf for guix-devel@gnu.org; Thu, 30 Jan 2014 16:16:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8yy5-0002tl-RQ for guix-devel@gnu.org; Thu, 30 Jan 2014 16:16:19 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:52621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8yy5-0002sY-E7 for guix-devel@gnu.org; Thu, 30 Jan 2014 16:16:13 -0500 In-Reply-To: <1391099831-14896-2-git-send-email-sreeharsha@totakura.in> (Sree Harsha Totakura's message of "Thu, 30 Jan 2014 17:37:11 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Sree Harsha Totakura Cc: guix-devel@gnu.org Sree Harsha Totakura skribis: > * gnunet/packages/gnunet.scm (gnunet): New variable. Thanks to Zerwas fo= r the initial recipe. > * gnu/package/patches/gnunet-fix-scheduler.patch: Patch to fix bug in Gnu= net's scheduler. > * gnu/package/patches/gnunet-fix-tests.patch: Patch to fix bugs in testca= ses and to disable testscases which rely on name resolution. > * gnu-system.am (dist_patch_DATA): Add the above two patch files. Excellent! Can you wrap lines to ~75 chars? Also, you can use =E2=80=98Co-authored-by: Zerwas=E2=80=99 if deemed appropriate here. s/Gnunet/GNUnet/ The .patch files above should just have =E2=80=9CNew files=E2=80=9D in the = commit log (see other commits for examples.) However, can you please move the description of what the patches do at the top of the patches themselves, possibly with a reference to the upstream commit/bug report/discussion? > + (arguments > + '(#:phases > + (let* ((check (assq 'check %standard-phases)) > + (alist (delete check %standard-phases)) > + (testsetup > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (setenv "GNUNET_PREFIX" out) > + (setenv "PATH" (string-append (getenv "PATH") ":" out = "/bin")) > + #t)))) > + (display %standard-phases) > + (alist-cons-after 'testsetup (car check) (cdr check) > + (alist-cons-after 'install 'testsetup testsetup > + alist))))) I think the =E2=80=98display=E2=80=99 is a leftover, right? ;-) I would rather write it this way: (let* ((check (assq-ref %standard-phases 'check)) (pre-check (lambda* ...))) (alist-cons-after 'pre-check 'check check (alist-cons-after 'install 'pre-check pre-check (alist-delete 'check %standard-phases)))) (Woow, this ought to be simpler...) > + (synopsis "Secure P2P networking framework with cool applications") > + (description > + "GNUnet is a framework for secure peer-to-peer networking that does = not > +use any centralized or otherwise trusted services. Our high-level goal i= s to > +provide a strong free software foundation for a global network that prov= ides > +security and in particular respects privacy. GNUnet started with an ide= a for > +anonymous censorship-resistant file-sharing, but has grown to incorporate > +other applications as well as many generic building blocks for secure > +networking applications. In particular, GNUnet now includes the GNU Name > +System, a privacy-preserving, decentralized public key infrastructure") Could you run =E2=80=98make sync-descriptions=E2=80=99 and use whatever syn= opsis and description it suggests? (That comes from the canonical GNU package database.) Thanks for the nice work! Ludo=E2=80=99.