unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add Julia.
Date: Mon, 23 Mar 2015 10:29:11 +0100	[thread overview]
Message-ID: <87h9tckqoo.fsf@gnu.org> (raw)
In-Reply-To: <idjoanndimb.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 20 Mar 2015 12:16:12 +0100")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> The release tarball comes with all dependencies bundled, but I tried
> hard to make it build against system libraries.  This didn't always
> work, unfortunately.
>
> libuv : Julia comes with a modified version of libuv and it won't build
>         with our libuv package at this point.  This has been confirmed
>         upstream[1].
>
> dSMFT : Upstream's Makefile does not have targets to build dSMFT as a
>         library.  The Makefile is only used to build test programmes.  I
>         have a rudimentary package for dSMFT ready, but it would have to
>         include a patch to the Makefile to actually build libraries.
>
> rmath : Julia uses a version of rmath that is patched to use the dSMFT
>         random number generator.  Upstream highly recommends using the
>         patched library.

OK.  It’s reasonable to leave them as is, perhaps with a link to your
message in a comment.

> suitesparse : Unfortunately, suitesparse only builds static libraries,
>         not shared ones, while Julia expects to find shared libraries.
>         I'm not sure what to patch here: Julia's build system so that it
>         builds shared libs from the suitesparse package output (rather
>         than the bundled tarball) or suitesparse such that it also
>         provides shared libs.

I would patch suitesparse to produce shared libs, but if it’s a
“hand-made” build system, it’ll probably have to produce either shared
libs or static libs, but not both (which would require building both PIC
and non-PIC objects, etc.)  Having it build shared libs only is probably
OK.

Regardless, it’s OK to push Julia as is for now, and adjust suitesparse
and Julia in eventual commits.

> This package depends on a couple of other packages that are still
> awaiting review:
>
> - double-conversion (patch attached below)
> - openblas[2] (needed because Julia doesn't build against Atlas)
> - utf8proc[3]

I think these two are done now, no?

> From dfe39329d60b38b684141cc0ce1d2bccd7ab637e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 12:11:35 +0100
> Subject: [PATCH 1/2] gnu: Add double-conversion.
>
> * gnu/packages/maths.scm (double-conversion): New variable.

LGTM.

> From 41550ffafa8da05b2cf8dfad66d44e6f43c9042c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 11:26:23 +0100
> Subject: [PATCH 2/2] gnu: Add Julia.
>
> * gnu/packages/julia.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

LGTM.

Thank you!

Ludo’.

  reply	other threads:[~2015-03-23  9:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 11:16 [PATCH] Add Julia Ricardo Wurmus
2015-03-23  9:29 ` Ludovic Courtès [this message]
2015-03-23 21:35 ` Mark H Weaver
2015-03-24 14:56   ` Mark H Weaver
2015-03-24 17:14     ` Ricardo Wurmus
2015-03-24 20:45       ` Ludovic Courtès
2015-03-25 16:20       ` Mark H Weaver
2015-03-25 18:24         ` Ricardo Wurmus
2015-03-25 21:00           ` Mark H Weaver
2015-03-26 15:19         ` Mark H Weaver
2015-03-26 16:58           ` Ludovic Courtès
2015-03-26 21:14           ` Ricardo Wurmus
2015-03-29 13:21             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9tckqoo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).