From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add Julia. Date: Mon, 23 Mar 2015 10:29:11 +0100 Message-ID: <87h9tckqoo.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZyfd-0006Js-9I for guix-devel@gnu.org; Mon, 23 Mar 2015 05:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZyfZ-0000gM-Th for guix-devel@gnu.org; Mon, 23 Mar 2015 05:29:17 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZyfZ-0000gI-QN for guix-devel@gnu.org; Mon, 23 Mar 2015 05:29:13 -0400 In-Reply-To: (Ricardo Wurmus's message of "Fri, 20 Mar 2015 12:16:12 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > The release tarball comes with all dependencies bundled, but I tried > hard to make it build against system libraries. This didn't always > work, unfortunately. > > libuv : Julia comes with a modified version of libuv and it won't build > with our libuv package at this point. This has been confirmed > upstream[1]. > > dSMFT : Upstream's Makefile does not have targets to build dSMFT as a > library. The Makefile is only used to build test programmes. I > have a rudimentary package for dSMFT ready, but it would have to > include a patch to the Makefile to actually build libraries. > > rmath : Julia uses a version of rmath that is patched to use the dSMFT > random number generator. Upstream highly recommends using the > patched library. OK. It=E2=80=99s reasonable to leave them as is, perhaps with a link to yo= ur message in a comment. > suitesparse : Unfortunately, suitesparse only builds static libraries, > not shared ones, while Julia expects to find shared libraries. > I'm not sure what to patch here: Julia's build system so that it > builds shared libs from the suitesparse package output (rather > than the bundled tarball) or suitesparse such that it also > provides shared libs. I would patch suitesparse to produce shared libs, but if it=E2=80=99s a =E2=80=9Chand-made=E2=80=9D build system, it=E2=80=99ll probably have to pr= oduce either shared libs or static libs, but not both (which would require building both PIC and non-PIC objects, etc.) Having it build shared libs only is probably OK. Regardless, it=E2=80=99s OK to push Julia as is for now, and adjust suitesp= arse and Julia in eventual commits. > This package depends on a couple of other packages that are still > awaiting review: > > - double-conversion (patch attached below) > - openblas[2] (needed because Julia doesn't build against Atlas) > - utf8proc[3] I think these two are done now, no? > From dfe39329d60b38b684141cc0ce1d2bccd7ab637e Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Fri, 20 Mar 2015 12:11:35 +0100 > Subject: [PATCH 1/2] gnu: Add double-conversion. > > * gnu/packages/maths.scm (double-conversion): New variable. LGTM. > From 41550ffafa8da05b2cf8dfad66d44e6f43c9042c Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Fri, 20 Mar 2015 11:26:23 +0100 > Subject: [PATCH 2/2] gnu: Add Julia. > > * gnu/packages/julia.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. LGTM. Thank you! Ludo=E2=80=99.