From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL.
Date: Sun, 29 Mar 2015 15:15:49 +0200 [thread overview]
Message-ID: <87h9t40wsa.fsf@gnu.org> (raw)
In-Reply-To: <87y4mnbyja.fsf@gmail.com> ("宋文武"'s message of "Mon, 23 Mar 2015 22:04:25 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> Fixes a regression introduced in 666aa99.
>>> Reported by Felipe López and David Thompson.
>>>
>>> * gnu/packages/sdl.scm (sdl)[inputs]: Add glu.
>>> [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with
>>> '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shared'.
>>
>> [...]
>>
>>> --- a/gnu/packages/sdl.scm
>>> +++ b/gnu/packages/sdl.scm
>>> @@ -60,8 +60,11 @@
>>> (build-system gnu-build-system)
>>> (arguments
>>> '(;; Explicitly link against shared libraries instead of dlopening them.
>>> - ;; For X11, ALSA, PulseAudio, etc.
>>> - #:configure-flags '("--disable-sdl-dlopen")
>>> + ;; For X11, ALSA, and PulseAudio.
>>> + ;; OpenGL library is still dlopened at runtime.
>>> + #:configure-flags '("--disable-alsa-shared"
>>> + "--disable-pulseaudio-shared"
>>> + "--disable-x11-shared")
>>
>> So without these flags libpulse.so, libalsa.so, etc. are dlopened?
>> (“disable shared” is a bit misleading in the flag names.)
> Yes.
OK. Could you change the comment to:
Don’t dlopen X11, ALSA, and PulseAudio.
>>> (native-inputs `(("pkg-config" ,pkg-config)))
>>> (inputs `(("libxrandr" ,libxrandr)
>>> ("mesa" ,mesa)
>>> + ("glu" ,glu)
>>
>> Because of --disable-x11-shared, glu must be found at configure time,
>> right?
> No, without glu, SDL's configure reported with:
> checking for OpenGL (GLX) support... no
OK.
OK to push with this tiny change, and sorry for the delay!
Thanks,
Ludo’.
prev parent reply other threads:[~2015-03-29 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 7:47 [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL 宋文武
2015-03-21 7:47 ` [PATCH 2/2] gnu: sdl: Explicity use mesa as OpenGL driver 宋文武
2015-03-21 21:26 ` Ludovic Courtès
2015-03-23 14:08 ` 宋文武
2015-03-21 21:25 ` [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL Ludovic Courtès
2015-03-23 14:04 ` 宋文武
2015-03-29 13:15 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9t40wsa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).