From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL.
Date: Sun, 29 Mar 2015 15:15:49 +0200
Message-ID: <87h9t40wsa.fsf@gnu.org>
References: <1426924046-10364-1-git-send-email-iyzsong@gmail.com>
	<87384y3uwf.fsf@gnu.org> <87y4mnbyja.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YcD4F-0005Eu-Jv
	for guix-devel@gnu.org; Sun, 29 Mar 2015 09:15:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YcD4C-00032u-Ah
	for guix-devel@gnu.org; Sun, 29 Mar 2015 09:15:55 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53860)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YcD4C-00032q-6v
	for guix-devel@gnu.org; Sun, 29 Mar 2015 09:15:52 -0400
In-Reply-To: <87y4mnbyja.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Mon, 23 Mar 2015 22:04:25 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>>
>>> Fixes a regression introduced in 666aa99.
>>> Reported by Felipe L=C3=B3pez and David Thompson.
>>>
>>> * gnu/packages/sdl.scm (sdl)[inputs]: Add glu.
>>>   [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with
>>>   '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shar=
ed'.
>>
>> [...]
>>
>>> --- a/gnu/packages/sdl.scm
>>> +++ b/gnu/packages/sdl.scm
>>> @@ -60,8 +60,11 @@
>>>      (build-system gnu-build-system)
>>>      (arguments
>>>       '(;; Explicitly link against shared libraries instead of dlopenin=
g them.
>>> -       ;; For X11, ALSA, PulseAudio, etc.
>>> -       #:configure-flags '("--disable-sdl-dlopen")
>>> +       ;; For X11, ALSA, and PulseAudio.
>>> +       ;; OpenGL library is still dlopened at runtime.
>>> +       #:configure-flags '("--disable-alsa-shared"
>>> +                           "--disable-pulseaudio-shared"
>>> +                           "--disable-x11-shared")
>>
>> So without these flags libpulse.so, libalsa.so, etc. are dlopened?
>> (=E2=80=9Cdisable shared=E2=80=9D is a bit misleading in the flag names.)
> Yes.

OK.  Could you change the comment to:

  Don=E2=80=99t dlopen X11, ALSA, and PulseAudio.

>>>      (native-inputs `(("pkg-config" ,pkg-config)))
>>>      (inputs `(("libxrandr" ,libxrandr)
>>>                ("mesa" ,mesa)
>>> +              ("glu" ,glu)
>>
>> Because of --disable-x11-shared, glu must be found at configure time,
>> right?
> No, without glu, SDL's configure reported with:
>   checking for OpenGL (GLX) support... no

OK.

OK to push with this tiny change, and sorry for the delay!

Thanks,
Ludo=E2=80=99.