unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Timestamps in ...-autoloads.el files
Date: Thu, 19 May 2016 11:12:29 +0300	[thread overview]
Message-ID: <87h9du1n6a.fsf@gmail.com> (raw)
In-Reply-To: <8737piyxvv.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 16 May 2016 14:45:40 +0200")

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Ludovic Courtès (2016-05-16 15:45 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> To recap: we use "gnu/packages/patches/emacs-source-date-epoch.patch" to
>> modify 'autoload-insert-section-header' function, and it should work,
>> but it doesn't.  IIUC this happens because "autoload.elc" file was
>> compiled using the unpatched "autoload.el", but first things first.  Try
>> the following recipe in Emacs (installed with Guix):
[...]
> Ideally, we
> should remove all the .elc files and rebuild them, but maybe there are
> bootstrapping issues.

The attached patch does this.  Happily there were no any issues.  Now
emacs packages will honor SOURCE_DATE_EPOCH.  Even autoloads that comes
with emacs itself (loaddefs.el, cl-loaddefs.el, etc.) will have a proper
timestamp.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-Remove-.elc-from-the-release-tarball.patch --]
[-- Type: text/x-patch, Size: 1365 bytes --]

From ca571f7631bf77ddc8ad6257fe165b4ff0ef5e6b Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Thu, 19 May 2016 11:01:40 +0300
Subject: [PATCH] gnu: emacs: Remove *.elc from the release tarball.

* gnu/packages/emacs.scm (emacs)[arguments]: Add 'remove-compiled-elisp'
  phase.
---
 gnu/packages/emacs.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 32ed722..0c15f63 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -91,6 +91,15 @@
              (substitute* (find-files "." "^Makefile\\.in$")
                (("/bin/pwd")
                 "pwd"))))
+         (add-after 'configure 'remove-compiled-elisp
+           (lambda _
+             ;; Emacs comes with compiled elisp (*.elc) and generated
+             ;; autoloads (*loaddefs.el) files.  This does not allow us to use
+             ;; "emacs-source-date-epoch.patch" effectively, so remove these
+             ;; files (using 'make bootstrap-clean'), as 'make' will recreate
+             ;; them.
+             (with-directory-excursion "lisp"
+               (zero? (system* "make" "bootstrap-clean")))))
          (add-after 'install 'remove-info.info
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Remove 'info.info', which is provided by Texinfo <= 6.0.
-- 
2.7.3


  parent reply	other threads:[~2016-05-19  8:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 23:09 Challenge substitute servers! Ludovic Courtès
2015-10-20  0:17 ` Daniel Pimentel
2015-10-20 14:38 ` [PATCHES] emacs: Changes for 'guix challenge' Alex Kost
2015-10-20 14:58   ` Ludovic Courtès
2015-10-20 17:40 ` Timestamps in ...-autoloads.el files Alex Kost
2015-10-20 19:38   ` Ludovic Courtès
2015-10-21 13:05     ` Alex Kost
2015-10-21 16:55       ` Ludovic Courtès
2015-11-02 16:50         ` Alex Kost
2015-11-03 13:27           ` Ludovic Courtès
2015-11-14 11:32             ` Alex Kost
2015-11-14 15:03               ` Ludovic Courtès
2015-11-14 20:39                 ` Alex Kost
2016-05-11 14:53         ` Alex Kost
2016-05-16 12:45           ` Ludovic Courtès
2016-05-16 20:52             ` Alex Kost
2016-05-17  9:12               ` Ludovic Courtès
2016-05-19 16:29                 ` Alex Kost
2016-05-20 12:02                   ` Ludovic Courtès
2016-05-20 13:38                     ` Leo Famulari
2016-05-21 10:49                       ` Alex Kost
2016-05-21 21:02                         ` Ludovic Courtès
2016-05-24  9:07                           ` Alex Kost
2016-05-20 21:14                     ` Alex Kost
2016-05-19  8:12             ` Alex Kost [this message]
2016-05-19 12:56               ` Ludovic Courtès
2016-05-21 10:31                 ` Alex Kost
2016-05-21 21:01                   ` Ludovic Courtès
2016-05-24  9:00                     ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9du1n6a.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).