unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Wojtek Kosior <koszko@koszko.org>
Cc: "John Kehayias" <john.kehayias@protonmail.com>,
	宋文武 <iyzsong@envs.net>,
	edk@beaver-labs.com, guix-devel@gnu.org
Subject: Re: Guix's python has pip's user dir in its loadpath
Date: Sat, 08 Jul 2023 01:08:30 -0400	[thread overview]
Message-ID: <87h6qfxa5t.fsf@gmail.com> (raw)
In-Reply-To: <20230707164405.0ce9dc4e.koszko@koszko.org> (Wojtek Kosior's message of "Fri, 7 Jul 2023 16:44:05 +0200")

Hello,

Wojtek Kosior <koszko@koszko.org> writes:

>> > I just saw this message and hurried myself up to test the patch to
>> > python-build-system that I made. Unfortunately, it turns out the
>> > "PYTHONNOUSERSITE=1" env var breaks pip which tries to install wheels to
>> > the system site directory and fails due to a read-only filesystem.  
>> 
>> I'm not sure I follow; why would PYTHONNOUSERSITE affect pip?  I thought
>> it should only appear in wrappers of Python executables, not be set in a
>> profile's environment (thus not affecting pip) ?
>
> Indeed. And once I make my change, PYTHONNOUSERSITE gets also placed in
> the wrapper of the `pip` executable.
>
>> Could you share the diff of the patch you tried so far?
>
> I am attaching the patch file.
>
> I was trying to test with
>
>     ./pre-inst-env guix shell -C --network --no-cwd python-xmldiff coreutils python-pip
>     pip install xmldiff==2.4
>     echo > ~/.local/lib/python3.10/site-packages/xmldiff/main.py
>     xmldiff --help
>
> Without my patch, we get an error on 4th line. With my patch, we get
> the "Read-only file system" error on the 2nd line

Neat!  I think maybe we could add a build argument called
e.g. '#:honor-user-site?' to disable the having PYTHONNOUSERSITE=1 in
the wrapper for a few select packages (e.g. pip, virtualenv, probably a
few others that are expected to work with or honor pip user-installed
Python packages).

-- 
Thanks,
Maxim


  reply	other threads:[~2023-07-08  5:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14  6:42 Guix's python has pip's user dir in its loadpath edk
2023-06-29 10:22 ` 宋文武
2023-07-01  3:13   ` Maxim Cournoyer
2023-07-01 11:32     ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-01 15:57       ` Maxim Cournoyer
2023-07-05 20:29         ` John Kehayias
2023-07-06 15:35           ` Maxim Cournoyer
2023-07-06 21:28             ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-07 13:32               ` Maxim Cournoyer
2023-07-07 14:44                 ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-08  5:08                   ` Maxim Cournoyer [this message]
2023-07-11 18:21                     ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6qfxa5t.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=edk@beaver-labs.com \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@envs.net \
    --cc=john.kehayias@protonmail.com \
    --cc=koszko@koszko.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).