From: Wojtek Kosior via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: "John Kehayias" <john.kehayias@protonmail.com>,
宋文武 <iyzsong@envs.net>,
edk@beaver-labs.com, guix-devel@gnu.org
Subject: Re: Guix's python has pip's user dir in its loadpath
Date: Tue, 11 Jul 2023 20:21:37 +0200 [thread overview]
Message-ID: <20230711202137.43c8b956.koszko@koszko.org> (raw)
In-Reply-To: <87h6qfxa5t.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]
> I think maybe we could add a build argument called
> e.g. '#:honor-user-site?' to disable the having PYTHONNOUSERSITE=1 in
> the wrapper for a few select packages (e.g. pip, virtualenv, probably a
> few others that are expected to work with or honor pip user-installed
> Python packages).
>
I just did[1] this (with some new developments described in the cover
letter). As this was my first attempt at sending patches to Guix,
please forgive my mistakes :)
Best,
Wojtek
[1] https://issues.guix.gnu.org/64573
-- (sig_start)
website: https://koszko.org/koszko.html
fingerprint: E972 7060 E3C5 637C 8A4F 4B42 4BC5 221C 5A79 FD1A
follow me on Fediverse: https://friendica.me/profile/koszko/profile
♥ R29kIGlzIHRoZXJlIGFuZCBsb3ZlcyBtZQ== | ÷ c2luIHNlcGFyYXRlZCBtZSBmcm9tIEhpbQ==
✝ YnV0IEplc3VzIGRpZWQgdG8gc2F2ZSBtZQ== | ? U2hhbGwgSSBiZWNvbWUgSGlzIGZyaWVuZD8=
-- (sig_end)
On Sat, 08 Jul 2023 01:08:30 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Hello,
>
> Wojtek Kosior <koszko@koszko.org> writes:
>
> >> > I just saw this message and hurried myself up to test the patch to
> >> > python-build-system that I made. Unfortunately, it turns out the
> >> > "PYTHONNOUSERSITE=1" env var breaks pip which tries to install wheels to
> >> > the system site directory and fails due to a read-only filesystem.
> >>
> >> I'm not sure I follow; why would PYTHONNOUSERSITE affect pip? I thought
> >> it should only appear in wrappers of Python executables, not be set in a
> >> profile's environment (thus not affecting pip) ?
> >
> > Indeed. And once I make my change, PYTHONNOUSERSITE gets also placed in
> > the wrapper of the `pip` executable.
> >
> >> Could you share the diff of the patch you tried so far?
> >
> > I am attaching the patch file.
> >
> > I was trying to test with
> >
> > ./pre-inst-env guix shell -C --network --no-cwd python-xmldiff coreutils python-pip
> > pip install xmldiff==2.4
> > echo > ~/.local/lib/python3.10/site-packages/xmldiff/main.py
> > xmldiff --help
> >
> > Without my patch, we get an error on 4th line. With my patch, we get
> > the "Read-only file system" error on the 2nd line
>
> Neat! I think maybe we could add a build argument called
> e.g. '#:honor-user-site?' to disable the having PYTHONNOUSERSITE=1 in
> the wrapper for a few select packages (e.g. pip, virtualenv, probably a
> few others that are expected to work with or honor pip user-installed
> Python packages).
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-07-11 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 6:42 Guix's python has pip's user dir in its loadpath edk
2023-06-29 10:22 ` 宋文武
2023-07-01 3:13 ` Maxim Cournoyer
2023-07-01 11:32 ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-01 15:57 ` Maxim Cournoyer
2023-07-05 20:29 ` John Kehayias
2023-07-06 15:35 ` Maxim Cournoyer
2023-07-06 21:28 ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-07 13:32 ` Maxim Cournoyer
2023-07-07 14:44 ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2023-07-08 5:08 ` Maxim Cournoyer
2023-07-11 18:21 ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711202137.43c8b956.koszko@koszko.org \
--to=guix-devel@gnu.org \
--cc=edk@beaver-labs.com \
--cc=iyzsong@envs.net \
--cc=john.kehayias@protonmail.com \
--cc=koszko@koszko.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).