From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: ‘strip’ phase
Date: Mon, 27 Oct 2014 13:16:49 +0100 [thread overview]
Message-ID: <87fve97ln2.fsf@gnu.org> (raw)
In-Reply-To: <87d29dj1yq.fsf@netris.org> (Mark H. Weaver's message of "Mon, 27 Oct 2014 05:28:45 -0400")
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
[...]
>> I think the ‘strip’ phase is fine this way: sure, it ends up invoking
>> ‘strip’ on files that are not ELF files, but it’s harmless. So we get
>> these extra warnings in the build log, but they are really harmless.
>
> Large numbers of spurious warnings are not harmless, because they make
> it unlikely that anyone will notice the warnings worth our attention.
> They condition us to ignore all warnings, because it's too much work to
> look through them all.
Right.
>> Conversely, attempts to be more selective may miss actual ELF files.
>
> True, but this is more harmless than the spurious warnings, IMO. It
> merely means that we failed to save some disk space.
>
> IMO, the best solution is to check for the presence of ELF headers
> ourselves. We already have ELF code in Guile master.
Yes, that sounds good. Instead of relying on Guile’s ELF code, perhaps
it would be enough to check for the presence of the ELF magic bytes?
Ludo’.
next prev parent reply other threads:[~2014-10-27 12:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 20:31 [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
2014-10-26 23:33 ` Mark H Weaver
2014-10-26 23:44 ` Pjotr Prins
2014-10-26 23:53 ` Pjotr Prins
2014-10-27 0:53 ` David Thompson
2014-10-27 1:44 ` Pjotr Prins
2014-10-27 1:43 ` Mark H Weaver
2014-10-27 1:56 ` Pjotr Prins
2014-10-27 4:11 ` Mark H Weaver
2014-10-27 9:05 ` ‘strip’ phase Ludovic Courtès
2014-10-27 9:28 ` Mark H Weaver
2014-10-27 12:16 ` Ludovic Courtès [this message]
2014-10-27 14:23 ` Mark H Weaver
2014-11-22 11:53 ` Ludovic Courtès
2014-10-27 5:17 ` [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fve97ln2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).