From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: =?utf-8?B?4oCYc3RyaXDigJk=?= phase
Date: Mon, 27 Oct 2014 13:16:49 +0100
Message-ID: <87fve97ln2.fsf@gnu.org>
References: <20141026203111.GA20849@thebird.nl> <87wq7mpfs0.fsf@yeeloong.lan>
	<20141026234436.GA21721@thebird.nl> <87siiap9s5.fsf@yeeloong.lan>
	<20141027015650.GB21971@thebird.nl> <87k33m179b.fsf@netris.org>
	<87tx2panmi.fsf_-_@gnu.org> <87d29dj1yq.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XijDu-0004jS-UB
	for guix-devel@gnu.org; Mon, 27 Oct 2014 08:16:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XijDq-0004Bb-5l
	for guix-devel@gnu.org; Mon, 27 Oct 2014 08:16:34 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:42312)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XijDp-0004BU-Vt
	for guix-devel@gnu.org; Mon, 27 Oct 2014 08:16:30 -0400
In-Reply-To: <87d29dj1yq.fsf@netris.org> (Mark H. Weaver's message of "Mon, 27
	Oct 2014 05:28:45 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:

[...]

>> I think the =E2=80=98strip=E2=80=99 phase is fine this way: sure, it end=
s up invoking
>> =E2=80=98strip=E2=80=99 on files that are not ELF files, but it=E2=80=99=
s harmless.  So we get
>> these extra warnings in the build log, but they are really harmless.
>
> Large numbers of spurious warnings are not harmless, because they make
> it unlikely that anyone will notice the warnings worth our attention.
> They condition us to ignore all warnings, because it's too much work to
> look through them all.

Right.

>> Conversely, attempts to be more selective may miss actual ELF files.
>
> True, but this is more harmless than the spurious warnings, IMO.  It
> merely means that we failed to save some disk space.
>
> IMO, the best solution is to check for the presence of ELF headers
> ourselves.  We already have ELF code in Guile master.

Yes, that sounds good.  Instead of relying on Guile=E2=80=99s ELF code, per=
haps
it would be enough to check for the presence of the ELF magic bytes?

Ludo=E2=80=99.