Re: gnu: Add mg.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com ("Taylan Ulrich "Bayırlı/Kammer\"") skribis:

> +              (snippet
> +               '(begin
> +                  (substitute* "Makefile.in"
> +                    (("-Werror") "")
> +                    (("-lcurses") "-lncurses")

OK.

> +                    (("/usr/bin/install" install)
> +                     (string-append install " -D")))))))

Here ‘install’ is bound to the complete match–i.e., “/usr/bin/install”.
So in effect, this clause keeps “/usr/bin/install” and appends ‘-D’,
which is why you have to patch it again in the ‘pre-configure’ phase.

It would be simpler to directly replace “/usr/bin/install” by “install
-D” in this snippet.

Likewise, “/usr/bin/strip” should be replaced by “strip” in the snippet.

In general, all the input-independent substitutions should go in the
snippet.

[...]

> +                   ;; Fix pathes in Makefile.in.

s/pathes/file names/.

> +                   (substitute* "Makefile.in"
> +                     (("(prefix=[[:blank:]]*)/usr/local" all prefix)
> +                      (string-append prefix (assoc-ref outputs "out")))

This is the only substitute* clause that should remain here.

Could you send an updated patch?

Thanks,
Ludo’.