From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu: Add mg.
Date: Wed, 26 Nov 2014 23:49:50 +0100
Message-ID: <87fvd5shkh.fsf@gnu.org>
References: <877fyh38ke.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XtlPK-0000Kc-2N
	for guix-devel@gnu.org; Wed, 26 Nov 2014 17:50:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XtlPE-0002Vy-Cw
	for guix-devel@gnu.org; Wed, 26 Nov 2014 17:49:58 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:41381)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XtlPE-0002Vq-68
	for guix-devel@gnu.org; Wed, 26 Nov 2014 17:49:52 -0500
In-Reply-To: <877fyh38ke.fsf@taylan.uni.cx> ("\"Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=5C\=22\=22's\?\=
	message of "Wed, 26 Nov 2014 23:23:29 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: taylanbayirli@gmail.com
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com ("Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer\"") skrib=
is:

> +              (snippet
> +               '(begin
> +                  (substitute* "Makefile.in"
> +                    (("-Werror") "")
> +                    (("-lcurses") "-lncurses")

OK.

> +                    (("/usr/bin/install" install)
> +                     (string-append install " -D")))))))

Here =E2=80=98install=E2=80=99 is bound to the complete match=E2=80=93i.e.,=
 =E2=80=9C/usr/bin/install=E2=80=9D.
So in effect, this clause keeps =E2=80=9C/usr/bin/install=E2=80=9D and appe=
nds =E2=80=98-D=E2=80=99,
which is why you have to patch it again in the =E2=80=98pre-configure=E2=80=
=99 phase.

It would be simpler to directly replace =E2=80=9C/usr/bin/install=E2=80=9D =
by =E2=80=9Cinstall
-D=E2=80=9D in this snippet.

Likewise, =E2=80=9C/usr/bin/strip=E2=80=9D should be replaced by =E2=80=9Cs=
trip=E2=80=9D in the snippet.

In general, all the input-independent substitutions should go in the
snippet.

[...]

> +                   ;; Fix pathes in Makefile.in.

s/pathes/file names/.

> +                   (substitute* "Makefile.in"
> +                     (("(prefix=3D[[:blank:]]*)/usr/local" all prefix)
> +                      (string-append prefix (assoc-ref outputs "out")))

This is the only substitute* clause that should remain here.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.