From: Paul van der Walt <paul@denknerd.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add cmus.
Date: Thu, 22 Oct 2015 11:26:15 +0200 [thread overview]
Message-ID: <87fv13s18o.fsf@denknerd.org> (raw)
In-Reply-To: <87vb9ziewh.fsf@elephly.net>
Hi Ricardo,
Thanks for your comments! Last night i already fixed some of these
issues when Ludo pointed them out.
On 2015-10-22 at 08:41, quoth Ricardo Wurmus:
> Please use ‘(file-name ...)’ here as the tarball is only named
> ‘v2.7.1.tar.gz’.
OK, good point. I admit that i wasn't sure about that (it was indeed in
the `guix lint` output), but i have now added that to both the dosbox
and cmus packages. I'll email the patches shortly (since i had already
pushed cmus after getting approval from Ludo — sorry for my overly hasty
actions then!).
> Putting the ‘#f’ on a separate line looks odd. Please put ‘#:tests? #f’
> on one line together with the margin comment.
Already done.
>> + ("pkg-config" ,pkg-config)
>
> This should be in native-inputs instead.
Already done.
>> + (description "Cmus is a small, fast and powerful console music player for
>> +Unix-like operating systems.")
>
> “for Unix-like operating systems” seems redundant as Guix only works on
> GNU systems.
Already done.
Thank you again!
p.
next prev parent reply other threads:[~2015-10-22 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 11:20 [PATCH 1/3] gnu: Add opusfile Paul van der Walt
2015-10-19 11:20 ` [PATCH 2/3] gnu: Add libcue Paul van der Walt
2015-10-21 19:29 ` Ludovic Courtès
2015-10-21 19:38 ` Paul van der Walt
2015-10-19 11:20 ` [PATCH 3/3] gnu: Add cmus Paul van der Walt
2015-10-21 19:35 ` Ludovic Courtès
2015-10-22 6:41 ` Ricardo Wurmus
2015-10-22 9:26 ` Paul van der Walt [this message]
2015-10-21 19:23 ` [PATCH 1/3] gnu: Add opusfile Ludovic Courtès
2015-10-21 19:35 ` Paul van der Walt
2015-10-22 0:05 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv13s18o.fsf@denknerd.org \
--to=paul@denknerd.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).