From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 3/3] gnu: Add cmus.
Date: Thu, 22 Oct 2015 11:26:15 +0200
Message-ID: <87fv13s18o.fsf@denknerd.org>
References: <1445253649-1582-1-git-send-email-paul@denknerd.org>
	<1445253649-1582-3-git-send-email-paul@denknerd.org>
	<87vb9ziewh.fsf@elephly.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpC8i-0004P4-21
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:26:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpC8e-00008R-OX
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:26:28 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:18092 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpC8e-00008G-Hm
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:26:24 -0400
In-reply-to: <87vb9ziewh.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Hi Ricardo,

Thanks for your comments!  Last night i already fixed some of these
issues when Ludo pointed them out.

On 2015-10-22 at 08:41, quoth Ricardo Wurmus:
> Please use =E2=80=98(file-name ...)=E2=80=99 here as the tarball is onl=
y named
> =E2=80=98v2.7.1.tar.gz=E2=80=99.

OK, good point.  I admit that i wasn't sure about that (it was indeed in
the `guix lint` output), but i have now added that to both the dosbox
and cmus packages.  I'll email the patches shortly (since i had already
pushed cmus after getting approval from Ludo =E2=80=94 sorry for my overl=
y hasty
actions then!).

> Putting the =E2=80=98#f=E2=80=99 on a separate line looks odd.  Please =
put =E2=80=98#:tests? #f=E2=80=99
> on one line together with the margin comment.

Already done.

>> +       ("pkg-config" ,pkg-config)
>
> This should be in native-inputs instead.

Already done.

>> +     (description "Cmus is a small, fast and powerful console music p=
layer for
>> +Unix-like operating systems.")
>
> =E2=80=9Cfor Unix-like operating systems=E2=80=9D seems redundant as Gu=
ix only works on
> GNU systems.

Already done.

Thank you again!
p.