* New package: xmlstarlet
@ 2015-12-28 11:59 Raimon Grau
2015-12-28 19:41 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Raimon Grau @ 2015-12-28 11:59 UTC (permalink / raw)
To: guix-devel@gnu.org
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Hi,
I've packaged xmlstarlet. I tried to follow all conventions, but I
may have missed some... So, any comments are welcome :)
Cheers,
[-- Attachment #2: XmlStarlet --]
[-- Type: text/x-diff, Size: 1916 bytes --]
From 592e889da41a92f029526283c7c837cd426f21cb Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimon@3scale.net>
Date: Mon, 28 Dec 2015 11:51:59 +0000
Subject: [PATCH] gnu: Add xmlstarlet.
* gnu/packages/xml.scm (xmlstarlet): New variable.
---
gnu/packages/xml.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 8288869..5309aea 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -6,6 +6,7 @@
;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -707,3 +708,32 @@ Cflags: -I${includedir}
C++ programming langauge.")
(home-page "http://www.grinninglizard.com/tinyxml/index.html")
(license license:zlib)))
+
+(define-public xmlstarlet
+ (package
+ (name "xmlstarlet")
+ (version "1.6.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://downloads.sourceforge.net/project/xmlstar/xmlstarlet/"
+ version
+ "/xmlstarlet-"
+ version
+ ".tar.gz"))
+ (sha256
+ (base32
+ "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("libxslt" ,libxslt)
+ ("libxml2" ,libxml2)))
+ (home-page "http://xmlstar.sourceforge.net/")
+ (synopsis "Command line XML Toolkit")
+ (description "XMLStarlet is a set of command line utilities (tools)
+which can be used to transform, query, validate, and edit XML
+documents and files using simple set of shell commands in similar way
+it is done for plain text files using UNIX grep, sed, awk, diff,
+patch, join, etc commands.")
+ (license license:x11)))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: New package: xmlstarlet
2015-12-28 11:59 New package: xmlstarlet Raimon Grau
@ 2015-12-28 19:41 ` Ricardo Wurmus
2015-12-28 21:09 ` Raimon Grau
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2015-12-28 19:41 UTC (permalink / raw)
To: Raimon Grau; +Cc: guix-devel@gnu.org
Hi Raimon,
thanks for your patch! Did you use “guix lint xmlstarlet”?
> From 592e889da41a92f029526283c7c837cd426f21cb Mon Sep 17 00:00:00 2001
> From: Raimon Grau <raimon@3scale.net>
> Date: Mon, 28 Dec 2015 11:51:59 +0000
> Subject: [PATCH] gnu: Add xmlstarlet.
> * gnu/packages/xml.scm (xmlstarlet): New variable.
> ---
> gnu/packages/xml.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 8288869..5309aea 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -6,6 +6,7 @@
> ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -707,3 +708,32 @@ Cflags: -I${includedir}
> C++ programming langauge.")
> (home-page "http://www.grinninglizard.com/tinyxml/index.html")
> (license license:zlib)))
> +
> +(define-public xmlstarlet
> + (package
> + (name "xmlstarlet")
> + (version "1.6.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://downloads.sourceforge.net/project/xmlstar/xmlstarlet/"
> + version
> + "/xmlstarlet-"
> + version
> + ".tar.gz"))
You might be able to use “mirror://sourceforge/” instead. I also think
it looks nicer to have fewer lines here, e.g.:
(uri (string-append "mirror://sourceforge/xmlstar/xmlstarlet/"
version "/xmlstarlet-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("libxslt" ,libxslt)
> + ("libxml2" ,libxml2)))
> + (home-page "http://xmlstar.sourceforge.net/")
> + (synopsis "Command line XML Toolkit")
“toolkit” rather than “Toolkit”. But maybe there’s a better synopsis
that tells us a little more about the tools? (I cannot suggest anything
better.)
> + (description "XMLStarlet is a set of command line utilities (tools)
> +which can be used to transform, query, validate, and edit XML
> +documents and files using simple set of shell commands in similar way
> +it is done for plain text files using UNIX grep, sed, awk, diff,
> +patch, join, etc commands.")
This is a little hard to read and the comparison with coreutils isn’t
very helpful (what does this really mean?). I’d write the first
sentence like this:
"XMLStarlet is a set of command line utilities which can be used to
transform, query, validate, and edit XML documents."
And then add another sentence about the commands. Note that there
should be two spaces between sentences.
> + (license license:x11)))
> --
> 2.6.3
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New package: xmlstarlet
2015-12-28 19:41 ` Ricardo Wurmus
@ 2015-12-28 21:09 ` Raimon Grau
2015-12-28 21:55 ` Leo Famulari
2016-01-05 1:37 ` Raimon Grau
0 siblings, 2 replies; 6+ messages in thread
From: Raimon Grau @ 2015-12-28 21:09 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel@gnu.org, Raimon Grau
[-- Attachment #1: Type: text/plain, Size: 3909 bytes --]
Ricardo Wurmus writes:
> Hi Raimon,
>
> thanks for your patch! Did you use “guix lint xmlstarlet”?
>
Yes I did use it. I had some issues running it in a guix checkout, but
eventually got to run it:
http://puntoblogspot.blogspot.com.es/2015/12/linting-guix-packages.html
>> From 592e889da41a92f029526283c7c837cd426f21cb Mon Sep 17 00:00:00 2001
>> From: Raimon Grau <raimon@3scale.net>
>> Date: Mon, 28 Dec 2015 11:51:59 +0000
>> Subject: [PATCH] gnu: Add xmlstarlet.
>
>> * gnu/packages/xml.scm (xmlstarlet): New variable.
>> ---
>> gnu/packages/xml.scm | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>
>> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
>> index 8288869..5309aea 100644
>> --- a/gnu/packages/xml.scm
>> +++ b/gnu/packages/xml.scm
>> @@ -6,6 +6,7 @@
>> ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>> ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
>> +;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -707,3 +708,32 @@ Cflags: -I${includedir}
>> C++ programming langauge.")
>> (home-page "http://www.grinninglizard.com/tinyxml/index.html")
>> (license license:zlib)))
>> +
>> +(define-public xmlstarlet
>> + (package
>> + (name "xmlstarlet")
>> + (version "1.6.1")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "http://downloads.sourceforge.net/project/xmlstar/xmlstarlet/"
>> + version
>> + "/xmlstarlet-"
>> + version
>> + ".tar.gz"))
>
> You might be able to use “mirror://sourceforge/” instead. I also think
> it looks nicer to have fewer lines here, e.g.:
>
> (uri (string-append "mirror://sourceforge/xmlstar/xmlstarlet/"
> version "/xmlstarlet-" version ".tar.gz"))
>
Thanks, fixed.
>> + (sha256
>> + (base32
>> + "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
>> + (build-system gnu-build-system)
>> + (inputs
>> + `(("libxslt" ,libxslt)
>> + ("libxml2" ,libxml2)))
>> + (home-page "http://xmlstar.sourceforge.net/")
>> + (synopsis "Command line XML Toolkit")
>
> “toolkit” rather than “Toolkit”. But maybe there’s a better synopsis
> that tells us a little more about the tools? (I cannot suggest anything
> better.)
>
>> + (description "XMLStarlet is a set of command line utilities (tools)
>> +which can be used to transform, query, validate, and edit XML
>> +documents and files using simple set of shell commands in similar way
>> +it is done for plain text files using UNIX grep, sed, awk, diff,
>> +patch, join, etc commands.")
>
> This is a little hard to read and the comparison with coreutils isn’t
> very helpful (what does this really mean?). I’d write the first
> sentence like this:
>
> "XMLStarlet is a set of command line utilities which can be used to
> transform, query, validate, and edit XML documents."
>
> And then add another sentence about the commands. Note that there
> should be two spaces between sentences.
I agree the comparison with coreutils is not very easy to understand,
but it's how the package is defined in its home page
(http://xmlstar.sourceforge.net/overview.php).
As a '2nd sentence' the home page says:
"This set of command line utilities can be used by those who deal with many XML
documents on UNIX shell command prompt as well as for automated XML processing
with shell scripts."
Which is not very clear either.
I'm attaching the modified version with all but the description change,
in case anyone knows how to reword it and integrate it already. If not,
any suggestions?
Cheers,
Rai
[-- Attachment #2: 0001-gnu-Add-xmlstarlet.patch --]
[-- Type: text/x-diff, Size: 1854 bytes --]
From 2ce1d71995a15a8672d7956e15540f6ca629487a Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimon@3scale.net>
Date: Mon, 28 Dec 2015 11:51:59 +0000
Subject: [PATCH] gnu: Add xmlstarlet.
* gnu/packages/xml.scm (xmlstarlet): New variable.
---
gnu/packages/xml.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 8288869..8c99ddc 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -6,6 +6,7 @@
;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -707,3 +708,28 @@ Cflags: -I${includedir}
C++ programming langauge.")
(home-page "http://www.grinninglizard.com/tinyxml/index.html")
(license license:zlib)))
+
+(define-public xmlstarlet
+ (package
+ (name "xmlstarlet")
+ (version "1.6.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/xmlstar/xmlstarlet/"
+ version "/xmlstarlet-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("libxslt" ,libxslt)
+ ("libxml2" ,libxml2)))
+ (home-page "http://xmlstar.sourceforge.net/")
+ (synopsis "Command line XML toolkit")
+ (description "XMLStarlet is a set of command line utilities (tools)
+which can be used to transform, query, validate, and edit XML
+documents and files using simple set of shell commands in similar way
+it is done for plain text files using UNIX grep, sed, awk, diff,
+patch, join, etc commands.")
+ (license license:x11)))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: New package: xmlstarlet
2015-12-28 21:09 ` Raimon Grau
@ 2015-12-28 21:55 ` Leo Famulari
2016-01-05 1:37 ` Raimon Grau
1 sibling, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2015-12-28 21:55 UTC (permalink / raw)
To: Raimon Grau; +Cc: guix-devel@gnu.org
On Mon, Dec 28, 2015 at 09:09:42PM +0000, Raimon Grau wrote:
> Ricardo Wurmus writes:
>
> > Hi Raimon,
> >
> > thanks for your patch! Did you use “guix lint xmlstarlet”?
> >
>
> Yes I did use it. I had some issues running it in a guix checkout, but
> eventually got to run it:
> http://puntoblogspot.blogspot.com.es/2015/12/linting-guix-packages.html
I think that `guix environment guix` should provide gnutls.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New package: xmlstarlet
2015-12-28 21:09 ` Raimon Grau
2015-12-28 21:55 ` Leo Famulari
@ 2016-01-05 1:37 ` Raimon Grau
2016-01-07 14:58 ` Ricardo Wurmus
1 sibling, 1 reply; 6+ messages in thread
From: Raimon Grau @ 2016-01-05 1:37 UTC (permalink / raw)
To: Raimon Grau; +Cc: guix-devel@gnu.org
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
Raimon Grau writes:
> I'm attaching the modified version with all but the description change,
> in case anyone knows how to reword it and integrate it already. If not,
> any suggestions?
I reworded it a bit, and added more concrete info on how one can
modify the xmls (find using Xpath and edit using (E)XSLT).
[-- Attachment #2: Xmlstarlet package --]
[-- Type: text/x-diff, Size: 1802 bytes --]
From c4695d8d53098081a79c7c26531e15fbf03b8b3d Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimon@3scale.net>
Date: Mon, 28 Dec 2015 11:51:59 +0000
Subject: [PATCH] gnu: Add xmlstarlet.
* gnu/packages/xml.scm (xmlstarlet): New variable.
---
gnu/packages/xml.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 8288869..196cec2 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -6,6 +6,7 @@
;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -707,3 +708,26 @@ Cflags: -I${includedir}
C++ programming langauge.")
(home-page "http://www.grinninglizard.com/tinyxml/index.html")
(license license:zlib)))
+
+(define-public xmlstarlet
+ (package
+ (name "xmlstarlet")
+ (version "1.6.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/xmlstar/xmlstarlet/"
+ version "/xmlstarlet-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("libxslt" ,libxslt)
+ ("libxml2" ,libxml2)))
+ (home-page "http://xmlstar.sourceforge.net/")
+ (synopsis "Command line XML toolkit")
+ (description "XMLStarlet is a set of command line utilities
+which can be used to transform, query, validate, and edit XML
+documents. XPath is used to match and extract data, and elements can be added, deleted or modified using XSLT and EXSLT.")
+ (license license:x11)))
--
2.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: New package: xmlstarlet
2016-01-05 1:37 ` Raimon Grau
@ 2016-01-07 14:58 ` Ricardo Wurmus
0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2016-01-07 14:58 UTC (permalink / raw)
To: Raimon Grau; +Cc: guix-devel@gnu.org
Raimon Grau <raimonster@gmail.com> writes:
> Raimon Grau writes:
>> I'm attaching the modified version with all but the description change,
>> in case anyone knows how to reword it and integrate it already. If not,
>> any suggestions?
>
> I reworded it a bit, and added more concrete info on how one can
> modify the xmls (find using Xpath and edit using (E)XSLT).
It looks good to me (with the exception of the over-long line in the
description). I’ll push it with that change.
Thanks!
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-07 14:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-28 11:59 New package: xmlstarlet Raimon Grau
2015-12-28 19:41 ` Ricardo Wurmus
2015-12-28 21:09 ` Raimon Grau
2015-12-28 21:55 ` Leo Famulari
2016-01-05 1:37 ` Raimon Grau
2016-01-07 14:58 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).