unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: default tar format for "make dist" and patch file length
Date: Wed, 17 Nov 2021 14:39:38 -0800	[thread overview]
Message-ID: <87fsru8l05.fsf@ponder> (raw)
In-Reply-To: <874k8bxbit.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]

On 2021-11-17, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@debian.org> skribis:
>
>> Ideally, "guix lint" would be run and issues fixed before applying
>> patches ... !
>
> On the bright side, that there’s just a dozen of issues on 20K packages
> suggests it’s usually run.  :-)
>
> I think we’re used to running it for new packages but not when modifying
> an existing package, which is probably when issues like that are
> introduced.

Sounds plausible.

My guess is this is triggered from folks using "git format-patch" and
dumping the files into gnu/packages/patches, which probably has a
default length that is a little too long in this case.

Another option that would help a little would be to drop the .patch
suffix, it's kind of redundant to have gnu/packages/patches/*.patch

>> Is it worth adding an inexpensive check to etc/git/pre-push that also
>> checks for file-length and fails to push due to this issue potentially
>> breaking "make dist"?
>
> Could be.

This basically mimics the check that guix-lint does:

for p in $(find gnu/packages/patches -type f ) ; do
  if [ "$(echo guix-2.0.0rc3-10000-1234567890/${p} | wc -c)" -ge "99" ]
  then
    echo $p
    exit 1
  fi
done

Would something like that be cheap enough to consider adding to
etc/git/pre-push? Are "find" and "wc" reasonable dependencies to assume
they are available?

Obviously, have to wait until they are all fixed, some of which probably
require going through core-updates... or start with a more conservative
but still useful length-check.


>> A different angle might be to actually use a different tar format:
>>
>>   https://www.gnu.org/software/tar/manual/html_section/Formats.html
>>
>> I would guess "make dist" is using the tar "v7" format, based on the 99
>> character length limit for files. Most of the other formats have no file
>> length limit or a longer limit.
>
> Yes, we could also do that.

Struggling to figure out how to do that; seems automake is very inclined
to use the old format... anyone with sufficient auto* skills to try and
upgrade the "make dist" to pass one of the newer --format= arguments to
tar?


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2021-11-17 22:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  0:34 default tar format for "make dist" and patch file length Vagrant Cascadian
2021-11-17 11:32 ` Ludovic Courtès
2021-11-17 22:39   ` Vagrant Cascadian [this message]
2021-11-17 23:49     ` Vagrant Cascadian
2021-11-19 14:54       ` Ludovic Courtès
2021-11-20  4:39         ` Philip McGrath
2021-11-20  5:21           ` Vagrant Cascadian
2021-11-24 21:27             ` Vagrant Cascadian
2021-11-22  2:03     ` Maxim Cournoyer
2021-11-22 11:31       ` Ludovic Courtès
2021-11-22 20:14         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsru8l05.fsf@ponder \
    --to=vagrant@debian.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).