From: "Ludovic Courtès" <ludo@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: guix-devel@gnu.org
Subject: Re: default tar format for "make dist" and patch file length
Date: Fri, 19 Nov 2021 15:54:13 +0100 [thread overview]
Message-ID: <87y25kjiwa.fsf@gnu.org> (raw)
In-Reply-To: <87czmy8hr6.fsf@ponder> (Vagrant Cascadian's message of "Wed, 17 Nov 2021 15:49:49 -0800")
Hello,
Vagrant Cascadian <vagrant@debian.org> skribis:
> Another strategy would be to reduce the overly cautious lint check:
>
> diff --git a/guix/lint.scm b/guix/lint.scm
> index ac2e7b3841..e795c466b1 100644
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -957,7 +957,7 @@ (define (starts-with-package-name? file-name)
>
> ;; Check whether we're reaching tar's maximum file name length.
> (let ((prefix (string-length (%distro-directory)))
> - (margin (string-length "guix-2.0.0rc3-10000-1234567890/"))
> + (margin (string-length "guix-2.0.0rc3-10000-12345678/"))
> (max 99))
> (filter-map (match-lambda
> ((? string? patch)
>
>
> That leaves only two packages on master in violation of the lint check,
> and those are both updatable directly on master, and "make dist" still
> works with those two packages as they are, in my experience.
>
> I think that's fairly safe to do, actually, as "make dist" on
> core-updates-frozen currently produces a tarball prefixed with:
>
> guix-1.3.0.10380-fe257/
>
> If guix keeps bumping it's version into the double-digits, an
> rc-version, and it surpasses 99999 commits, and an extra character for
> the git commit hash, this still leaves considerable wiggle-room:
>
> guix-10.0.0rc0-123456-abcde0/
> vs.
> guix-2.0.0rc3-10000-12345678/
>
> So, I guess I'm leaning towards making the guix lint check a little more
> lenient.
>
> Thoughts?
That sounds even better, I’m all for it (changing (guix lint) + fixing
the two remaining issues)!
Ludo’.
next prev parent reply other threads:[~2021-11-19 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 0:34 default tar format for "make dist" and patch file length Vagrant Cascadian
2021-11-17 11:32 ` Ludovic Courtès
2021-11-17 22:39 ` Vagrant Cascadian
2021-11-17 23:49 ` Vagrant Cascadian
2021-11-19 14:54 ` Ludovic Courtès [this message]
2021-11-20 4:39 ` Philip McGrath
2021-11-20 5:21 ` Vagrant Cascadian
2021-11-24 21:27 ` Vagrant Cascadian
2021-11-22 2:03 ` Maxim Cournoyer
2021-11-22 11:31 ` Ludovic Courtès
2021-11-22 20:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y25kjiwa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).