Broken lisp-fill-paragraph post Emacs 28 update

Broken lisp-fill-paragraph post Emacs 28 update

[Maxim Cournoyer]

Hi,

If you too have been wondering why hitting M-q on package descriptions
doesn't produce the intended effect anymore (the first line of text
protrudes beyond the fill-column value), this may be of interest.

The problem was introduced in commit 9bf367e1848, which aimed to improve
the handling of Elisp docstrings.  To revert to the old version (the one
that shipped with Emacs 27), you can put this in your .emacs:

--8<---------------cut here---------------start------------->8---
(require 'lisp-mode)
(defun lisp-fill-paragraph (&optional justify)
  (interactive "P")
  (or (fill-comment-paragraph justify)
      (let ((paragraph-start
             (concat paragraph-start
                     "\\|\\s-*\\([(;\"]\\|\\s-:\\|`(\\|#'(\\)"))
	    (paragraph-separate
	     (concat paragraph-separate "\\|\\s-*\".*[,\\.]$"))
            (fill-column (if (and (integerp emacs-lisp-docstring-fill-column)
                                  (derived-mode-p 'emacs-lisp-mode))
                             emacs-lisp-docstring-fill-column
                           fill-column)))
	(fill-paragraph justify))
      ;; Never return nil.
      t))
--8<---------------cut here---------------end--------------->8---

For more details, you can refer to the (now closed) upstream bug report
here [0].

[0]  https://issues.guix.gnu.org/56197

Happy hacking!

Maxim

Re: Broken lisp-fill-paragraph post Emacs 28 update

[Ricardo Wurmus]

Hi Maxim,

> The problem was introduced in commit 9bf367e1848, which aimed to improve
> the handling of Elisp docstrings.  To revert to the old version (the one
> that shipped with Emacs 27), you can put this in your .emacs:
>
> (require 'lisp-mode)
> (defun lisp-fill-paragraph (&optional justify)
>   (interactive "P")
>   (or (fill-comment-paragraph justify)
>       (let ((paragraph-start
>              (concat paragraph-start
>                      "\\|\\s-*\\([(;\"]\\|\\s-:\\|`(\\|#'(\\)"))
> 	    (paragraph-separate
> 	     (concat paragraph-separate "\\|\\s-*\".*[,\\.]$"))
>             (fill-column (if (and (integerp emacs-lisp-docstring-fill-column)
>                                   (derived-mode-p 'emacs-lisp-mode))
>                              emacs-lisp-docstring-fill-column
>                            fill-column)))
> 	(fill-paragraph justify))
>       ;; Never return nil.
>       t))
>
> For more details, you can refer to the (now closed) upstream bug report
> here [0].
>
> [0]  https://issues.guix.gnu.org/56197

Oof, that’s a frustrating discussion.  Interesting how it took just
*one* comment to dismiss the new bug report with “the votes are in” :-/

Thanks for the procedure definition above.  Do you think we should
enable this by default in the guix-devel minor mode?

-- 
Ricardo

Re: Broken lisp-fill-paragraph post Emacs 28 update

[Maxim Cournoyer]

Hi,

Ricardo Wurmus <rekado@elephly.net> writes:

> Hi Maxim,
>
>> The problem was introduced in commit 9bf367e1848, which aimed to improve
>> the handling of Elisp docstrings.  To revert to the old version (the one
>> that shipped with Emacs 27), you can put this in your .emacs:
>>
>> (require 'lisp-mode)
>> (defun lisp-fill-paragraph (&optional justify)
>>   (interactive "P")
>>   (or (fill-comment-paragraph justify)
>>       (let ((paragraph-start
>>              (concat paragraph-start
>>                      "\\|\\s-*\\([(;\"]\\|\\s-:\\|`(\\|#'(\\)"))
>> 	    (paragraph-separate
>> 	     (concat paragraph-separate "\\|\\s-*\".*[,\\.]$"))
>>             (fill-column (if (and (integerp emacs-lisp-docstring-fill-column)
>>                                   (derived-mode-p 'emacs-lisp-mode))
>>                              emacs-lisp-docstring-fill-column
>>                            fill-column)))
>> 	(fill-paragraph justify))
>>       ;; Never return nil.
>>       t))
>>
>> For more details, you can refer to the (now closed) upstream bug report
>> here [0].
>>
>> [0]  https://issues.guix.gnu.org/56197
>
> Oof, that’s a frustrating discussion.  Interesting how it took just
> *one* comment to dismiss the new bug report with “the votes are in” :-/
>
> Thanks for the procedure definition above.  Do you think we should
> enable this by default in the guix-devel minor mode?

I went ahead and pushed a changed to our .dir-locals.el file that
reverts the behavior of lisp-fill-paragraph to that of Emacs 27 (see
commit c9fb789fe9) Along with an update to our paredit package, it does
the job.  Let me know if something doesn't work as advertised.

Thanks,

Maxim