Re: [PATCHES] Get elogind-service working as intended

[ludo@gnu.org (Ludovic Courtès)]

I just noticed I had this message in my draft folder, and it seems to
still be applicable, so here we go.  Sorry for the mess!

Mark H Weaver <mhw@netris.org> skribis:

> From 34d9f68b886fe590ff0efcd33d54e5d2f487ff70 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 16:58:08 -0400
> Subject: [PATCH 1/3] file-systems: Add %systemd-file-systems; add it to
>  %base-file-systems.
>
> * gnu/system/file-systems.scm (%systemd-file-systems): New variable.
>   (%base-file-systems): Add %systemd-file-systems.

[...]

> +(define %systemd-file-systems

I would call the variable ‘%elogind-file-systems’ for clarity, but
otherwise LGTM.

> From 59921d5bd704b07d25104b7a1921380892f60a80 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 17:12:38 -0400
> Subject: [PATCH 2/3] services: Add udev rules for (upower colord elogind) to
>  %desktop-services.
>
> * gnu/services/desktop.scm (%desktop-services): Replace the 'udev-service'
>   from %base-services.
> * gnu/services/base.scm (%base-services): Add a comment to keep them in sync.

OK.

> From 00b8791d7cea8f9702a004377756caefa243b23e Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 17:16:26 -0400
> Subject: [PATCH 3/3] services: elogind-configuration: Disable hibernation key
>  by default.
>
> * gnu/services/desktop.scm (<elogind-configuration>): Change the default value
>   of the 'handle-hibernate-key' field to 'ignore'.

OK.

Thanks!

Ludo’.