From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] Get elogind-service working as intended
Date: Thu, 10 Sep 2015 18:03:45 +0200
Message-ID: <87egi61cta.fsf@inria.fr>
References: <87a8t3mc2v.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Za4KE-0007Wh-Cm
	for guix-devel@gnu.org; Thu, 10 Sep 2015 12:03:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Za4KC-00065J-8l
	for guix-devel@gnu.org; Thu, 10 Sep 2015 12:03:49 -0400
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

I just noticed I had this message in my draft folder, and it seems to
still be applicable, so here we go.  Sorry for the mess!

Mark H Weaver <mhw@netris.org> skribis:

> From 34d9f68b886fe590ff0efcd33d54e5d2f487ff70 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 16:58:08 -0400
> Subject: [PATCH 1/3] file-systems: Add %systemd-file-systems; add it to
>  %base-file-systems.
>
> * gnu/system/file-systems.scm (%systemd-file-systems): New variable.
>   (%base-file-systems): Add %systemd-file-systems.

[...]

> +(define %systemd-file-systems

I would call the variable =E2=80=98%elogind-file-systems=E2=80=99 for clari=
ty, but
otherwise LGTM.

> From 59921d5bd704b07d25104b7a1921380892f60a80 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 17:12:38 -0400
> Subject: [PATCH 2/3] services: Add udev rules for (upower colord elogind)=
 to
>  %desktop-services.
>
> * gnu/services/desktop.scm (%desktop-services): Replace the 'udev-service'
>   from %base-services.
> * gnu/services/base.scm (%base-services): Add a comment to keep them in s=
ync.

OK.

> From 00b8791d7cea8f9702a004377756caefa243b23e Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 3 Sep 2015 17:16:26 -0400
> Subject: [PATCH 3/3] services: elogind-configuration: Disable hibernation=
 key
>  by default.
>
> * gnu/services/desktop.scm (<elogind-configuration>): Change the default =
value
>   of the 'handle-hibernate-key' field to 'ignore'.

OK.

Thanks!

Ludo=E2=80=99.