Re: [PATCH 1/2] gnu: lvtk: Build UI library.

[Ricardo Wurmus <rekado@elephly.net>]

Marius Bakke <mbakke@fastmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/audio.scm (lvtk)[inputs]: Add gtkmm-2.
>> [arguments]: Pass "-std=c++11" flag.
>> ---
>>  gnu/packages/audio.scm | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>> index 5de0681..d7bdc01 100644
>> --- a/gnu/packages/audio.scm
>> +++ b/gnu/packages/audio.scm
>> @@ -1653,9 +1653,16 @@ software.")
>>                       (setenv "LDFLAGS"
>>                               (string-append
>>                                "-L" (assoc-ref inputs "boost") "/lib "
>> -                              "-lboost_system")))))))
>> +                              "-lboost_system"))
>> +                     ;; Needed for gtkmm
>> +                     (substitute* '("src/wscript_build"
>> +                                    "examples/wscript_build")
>> +                       (("cxxflags.*= \\[" line)
>> +                        (string-append line "\"-std=c++11\", ")))
>> +                     #t)))))
>
> Is it not possible to pass this through #:make-flags? If not this LGTM,
> but would be nice with a comment about why make-flags won't work.

The waf-build-system doesn’t have any support for make-flags.  It flat
out ignores them and only runs “waf build”.  Whenever we want to change
flags in projects using waf we usually need to patch up the wscript(s).

I don’t know if there’s a standard way to amend certain flags.  If there
is we should add it to the waf-build-system.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net