From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 1/2] gnu: lvtk: Build UI library. Date: Sat, 03 Dec 2016 23:32:07 +0100 Message-ID: <87eg1o3aqg.fsf@elephly.net> References: <20161203194209.19164-1-rekado@elephly.net> <87k2bgbu6r.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDJLs-0003i3-Iv for guix-devel@gnu.org; Sat, 03 Dec 2016 18:04:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDJLo-00077O-KF for guix-devel@gnu.org; Sat, 03 Dec 2016 18:04:16 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21370) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDJLo-00077C-CC for guix-devel@gnu.org; Sat, 03 Dec 2016 18:04:12 -0500 In-reply-to: <87k2bgbu6r.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke writes: > Ricardo Wurmus writes: > >> * gnu/packages/audio.scm (lvtk)[inputs]: Add gtkmm-2. >> [arguments]: Pass "-std=c++11" flag. >> --- >> gnu/packages/audio.scm | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm >> index 5de0681..d7bdc01 100644 >> --- a/gnu/packages/audio.scm >> +++ b/gnu/packages/audio.scm >> @@ -1653,9 +1653,16 @@ software.") >> (setenv "LDFLAGS" >> (string-append >> "-L" (assoc-ref inputs "boost") "/lib " >> - "-lboost_system"))))))) >> + "-lboost_system")) >> + ;; Needed for gtkmm >> + (substitute* '("src/wscript_build" >> + "examples/wscript_build") >> + (("cxxflags.*= \\[" line) >> + (string-append line "\"-std=c++11\", "))) >> + #t))))) > > Is it not possible to pass this through #:make-flags? If not this LGTM, > but would be nice with a comment about why make-flags won't work. The waf-build-system doesn’t have any support for make-flags. It flat out ignores them and only runs “waf build”. Whenever we want to change flags in projects using waf we usually need to patch up the wscript(s). I don’t know if there’s a standard way to amend certain flags. If there is we should add it to the waf-build-system. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC http://elephly.net