* Updating a package
@ 2019-09-23 10:51 Divan Santana
2019-09-23 13:45 ` Danny Milosavljevic
0 siblings, 1 reply; 3+ messages in thread
From: Divan Santana @ 2019-09-23 10:51 UTC (permalink / raw)
To: Guix-devel
Hi Guix,
I'm trying to go about updating a package and submitting a patch.
A good learning process for me.
I managed to update the package, emacs-exwm and to build it successfully
via:
./pre-inst-env guix build emacs-exwm
Few Qs:
Should I do this after updating a package? make check to check all tests
pass? Or rather the CI does that?
Secondly, how do I go about testing this package on my system (laptop
running guix) to see if the updated package actually works?
I've done this in channels.scm
(list
(channel
(name 'guix)
(url "https://gitlab.com/divansantana/guix/")
(branch "master")))
And then updated to my fork, though not sure if that is the best way.
I suppose it may be better to test these things in a vm via guix vm.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Updating a package
2019-09-23 10:51 Updating a package Divan Santana
@ 2019-09-23 13:45 ` Danny Milosavljevic
2019-09-24 18:02 ` Divan Santana
0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2019-09-23 13:45 UTC (permalink / raw)
To: Divan Santana; +Cc: Guix-devel
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
Hi Divan,
On Mon, 23 Sep 2019 12:51:42 +0200
Divan Santana <divan@santanas.co.za> wrote:
> ./pre-inst-env guix build emacs-exwm
> Should I do this after updating a package? make check to check all tests
> pass?
In this case not really--since "make check" tests guix the package manager.
You didn't change the package manager, so it wouldn't help.
>Or rather the CI does that?
The CI does that and then it also builds all the other packages, not just
guix the package manager.
> Secondly, how do I go about testing this package on my system (laptop
> running guix) to see if the updated package actually works?
./pre-inst-env guix package -i emacs-exwm
The package is then installed into your profile and you can just use it like
any other packages installed in your profile.
> I've done this in channels.scm
>
> (list
> (channel
> (name 'guix)
> (url "https://gitlab.com/divansantana/guix/")
> (branch "master")))
>
> And then updated to my fork, though not sure if that is the best way.
That would work as well--but sounds like a lot of work. It is nicer to
do it your way if you want to *keep* your package across updates if
it doesn't make it into the main repository. Otherwise I don't think
your way gives you any advantage over just installing the package.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Updating a package
2019-09-23 13:45 ` Danny Milosavljevic
@ 2019-09-24 18:02 ` Divan Santana
0 siblings, 0 replies; 3+ messages in thread
From: Divan Santana @ 2019-09-24 18:02 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: Guix-devel
>> ./pre-inst-env guix build emacs-exwm
>
>> Should I do this after updating a package? make check to check all tests
>> pass?
>
> In this case not really--since "make check" tests guix the package manager.
> You didn't change the package manager, so it wouldn't help.
>
>>Or rather the CI does that?
>
> The CI does that and then it also builds all the other packages, not just
> guix the package manager.
>
>> Secondly, how do I go about testing this package on my system (laptop
>> running guix) to see if the updated package actually works?
>
> ./pre-inst-env guix package -i emacs-exwm
>
> The package is then installed into your profile and you can just use it like
> any other packages installed in your profile.
>
>> I've done this in channels.scm
>>
>> (list
>> (channel
>> (name 'guix)
>> (url "https://gitlab.com/divansantana/guix/")
>> (branch "master")))
>>
>> And then updated to my fork, though not sure if that is the best way.
>
> That would work as well--but sounds like a lot of work. It is nicer to
> do it your way if you want to *keep* your package across updates if
> it doesn't make it into the main repository. Otherwise I don't think
> your way gives you any advantage over just installing the package.
Great thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-24 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23 10:51 Updating a package Divan Santana
2019-09-23 13:45 ` Danny Milosavljevic
2019-09-24 18:02 ` Divan Santana
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).