unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: bridge-utils: Fix build system.
@ 2015-05-07 12:31 David Thompson
  2015-05-07 13:09 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: David Thompson @ 2015-05-07 12:31 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 137 bytes --]

Our bridge-utils build is totally broken, but was failing silently due
to issues with the Makefile.  Now it actually builds 'brctl'. :)


[-- Attachment #2: 0001-gnu-bridge-utils-Fix-build-system.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]

From 7a7a10874ae8ffb34c9edcb021b579d6bf0a287c Mon Sep 17 00:00:00 2001
From: David Thompson <davet@gnu.org>
Date: Wed, 6 May 2015 17:00:07 -0400
Subject: [PATCH] gnu: bridge-utils: Fix build system.

* gnu/packages/linux.scm (bridge-utils): Patch source to fix compilation
  error.  Patch Makefile to fail in case of future compilation errors.
---
 gnu/packages/linux.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 9ff753d..62d2777 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1033,6 +1033,17 @@ Linux-based operating systems.")
      '(#:phases (alist-cons-after
                  'unpack 'bootstrap
                  (lambda _
+                   ;; Fix "field ‘ip6’ has incomplete type" errors.
+                   (substitute* "libbridge/libbridge.h"
+                     (("#include <linux/if_bridge.h>")
+                      "#include <linux/in6.h>\n#include <linux/if_bridge.h>"))
+
+                   ;; Ensure that the entire build fails if one of the
+                   ;; sub-Makefiles fails.
+                   (substitute* "Makefile.in"
+                     (("\\$\\(MAKE\\) \\$\\(MFLAGS\\) -C \\$\\$x ;")
+                      "$(MAKE) $(MFLAGS) -C $$x || exit 1;"))
+
                    (zero? (system* "autoreconf" "-vf")))
                  %standard-phases)
        #:tests? #f))                              ; no 'check' target
-- 
2.1.4


[-- Attachment #3: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu: bridge-utils: Fix build system.
  2015-05-07 12:31 [PATCH] gnu: bridge-utils: Fix build system David Thompson
@ 2015-05-07 13:09 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-05-07 13:09 UTC (permalink / raw)
  To: David Thompson; +Cc: guix-devel

David Thompson <dthompson2@worcester.edu> skribis:

> From 7a7a10874ae8ffb34c9edcb021b579d6bf0a287c Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 6 May 2015 17:00:07 -0400
> Subject: [PATCH] gnu: bridge-utils: Fix build system.
>
> * gnu/packages/linux.scm (bridge-utils): Patch source to fix compilation
>   error.  Patch Makefile to fail in case of future compilation errors.

Looks good; thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-07 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-07 12:31 [PATCH] gnu: bridge-utils: Fix build system David Thompson
2015-05-07 13:09 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).