[PATCH] gnu: Add lxappearance.

[PATCH] gnu: Add lxappearance.

[Mathieu Lirzin]

[-- Attachment #1: 0001-gnu-Add-lxappearance.patch --]
[-- Type: text/x-diff, Size: 3106 bytes --]

From bbb9a32ded0c047fa50413afe8e2c6b50f89a8ee Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sat, 11 Jul 2015 08:25:14 +0200
Subject: [PATCH] gnu: Add lxappearance.

* gnu/packages/lxde.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/lxde.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 gnu/packages/lxde.scm

diff --git a/gnu-system.am b/gnu-system.am
index d6369b5..3ffa66a 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -192,6 +192,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/lsh.scm				\
   gnu/packages/lsof.scm				\
   gnu/packages/lua.scm				\
+  gnu/packages/lxde.scm				\
   gnu/packages/lxqt.scm				\
   gnu/packages/lynx.scm				\
   gnu/packages/m4.scm				\
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
new file mode 100644
index 0000000..5498f16
--- /dev/null
+++ b/gnu/packages/lxde.scm
@@ -0,0 +1,51 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lxde)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+(define-public lxappearance
+  (package
+    (name "lxappearance")
+    (version "0.6.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/projects/lxde/files/LXAppearance/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1phnv1b2jdj2vlibjyc9z01izcf3k5zxj8glsaf0i3vh77zqmqq9"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("intltool" ,intltool)
+                     ("pkg-config" ,pkg-config)))
+    (inputs `(("gtk+" ,gtk+-2)))
+    (synopsis "LXDE GTK+ theme switcher")
+    (description
+     "LXAppearance is a desktop-independent GTK+ theme switcher able to change
+themes, icons, and fonts used by GTK+ applications.")
+    (home-page "http://lxde.org")
+    (license license:gpl2+)))
+
+;;; lxde.scm ends here
-- 
2.1.4

Re: [PATCH] gnu: Add lxappearance.

[Alex Kost]

Mathieu Lirzin (2015-07-12 17:21 +0300) wrote:

[...]
> +(define-public lxappearance
> +  (package
> +    (name "lxappearance")
> +    (version "0.6.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://sourceforge/projects/lxde/files/LXAppearance/"

I think it should be:
> +                    "mirror://sourceforge/project/lxde/LXAppearance/"

guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"

gives some html file.  Otherwise it looks good to me.

-- 
Alex

Re: [PATCH] gnu: Add lxappearance.

[Mathieu Lirzin]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Alex Kost <alezost@gmail.com> writes:

> I think it should be:
>> +                    "mirror://sourceforge/project/lxde/LXAppearance/"
>
> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>
> gives some html file.  Otherwise it looks good to me.

fixed!

One last question: I've used "LXDE" and "LXAppearance" because it's the
most common way to write them and LXDE is a acronym for "Lightweight X11
Desktop Environment".  But Since we use the name "Gnome" (which is a
acronym), I wonder if we shouldn't use "Lxde" and "Lxappearance"
likewise.

--
Mathieu Lirzin


[-- Attachment #2: 0001-gnu-Add-lxappearance.patch --]
[-- Type: text/x-diff, Size: 3088 bytes --]

From 6f27db9f084a938f055787c06aaad3bb61ee449f Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sat, 11 Jul 2015 08:25:14 +0200
Subject: [PATCH] gnu: Add lxappearance.

* gnu/packages/lxde.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/lxde.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 gnu/packages/lxde.scm

diff --git a/gnu-system.am b/gnu-system.am
index fc6517c..368c30e 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -193,6 +193,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/lsh.scm				\
   gnu/packages/lsof.scm				\
   gnu/packages/lua.scm				\
+  gnu/packages/lxde.scm				\
   gnu/packages/lxqt.scm				\
   gnu/packages/lynx.scm				\
   gnu/packages/m4.scm				\
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
new file mode 100644
index 0000000..cf837f5
--- /dev/null
+++ b/gnu/packages/lxde.scm
@@ -0,0 +1,49 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lxde)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+(define-public lxappearance
+  (package
+    (name "lxappearance")
+    (version "0.6.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/project/lxde"
+                                  "LXAppearance/" name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1phnv1b2jdj2vlibjyc9z01izcf3k5zxj8glsaf0i3vh77zqmqq9"))))
+    (build-system gnu-build-system)
+    (inputs `(("gtk+" ,gtk+-2)))
+    (native-inputs `(("intltool"   ,intltool)
+                     ("pkg-config" ,pkg-config)))
+    (synopsis "LXDE GTK+ theme switcher")
+    (description "LXAppearance is a desktop-independent GTK+ theme switcher
+able to change themes, icons, and fonts used by GTK+ applications.")
+    (home-page "http://lxde.org")
+    (license license:gpl2+)))
+
+;;; lxde.scm ends here
-- 
2.1.4

Re: [PATCH] gnu: Add lxappearance.

[Ludovic Courtès]

Mathieu Lirzin <mthl@openmailbox.org> skribis:

> One last question: I've used "LXDE" and "LXAppearance" because it's the
> most common way to write them and LXDE is a acronym for "Lightweight X11
> Desktop Environment".  But Since we use the name "Gnome" (which is a
> acronym), I wonder if we shouldn't use "Lxde" and "Lxappearance"
> likewise.

It’s a mistake: the real name is “GNOME”.  In general I think we should
use the spelling and case that upstream uses, so “LXDE” in that case.

> From 6f27db9f084a938f055787c06aaad3bb61ee449f Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Sat, 11 Jul 2015 08:25:14 +0200
> Subject: [PATCH] gnu: Add lxappearance.
>
> * gnu/packages/lxde.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Also LGTM.  :-)

Thanks!

Ludo’.

Re: [PATCH] gnu: Add lxappearance.

[Mark H Weaver]

Mathieu Lirzin <mthl@openmailbox.org> writes:

> Alex Kost <alezost@gmail.com> writes:
>
>> I think it should be:
>>> +                    "mirror://sourceforge/project/lxde/LXAppearance/"
>>
>> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>>
>> gives some html file.  Otherwise it looks good to me.
>
> fixed!

The lxappearance builds are failing on Hydra, because the hash of the
downloaded source doesn't match the one in the package description:

  http://hydra.gnu.org/eval/105500#tabs-new
  http://hydra.gnu.org/build/588561
  http://hydra.gnu.org/build/588561/nixlog/1/raw

Can you look into it?

      Mark

Re: [PATCH] gnu: Add lxappearance.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Mark H Weaver (2015-07-16 19:41 +0300) wrote:

> Mathieu Lirzin <mthl@openmailbox.org> writes:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>> I think it should be:
>>>> +                    "mirror://sourceforge/project/lxde/LXAppearance/"
>>>
>>> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>>>
>>> gives some html file.  Otherwise it looks good to me.
>>
>> fixed!
>
> The lxappearance builds are failing on Hydra, because the hash of the
> downloaded source doesn't match the one in the package description:
>
>   http://hydra.gnu.org/eval/105500#tabs-new
>   http://hydra.gnu.org/build/588561
>   http://hydra.gnu.org/build/588561/nixlog/1/raw
>
> Can you look into it?

It looks like there are problems with "sourceforge" itself currently.
I've tried to download several sources from it and every time I got an
html with the following contents instead:


[-- Attachment #2: sf.htm --]
[-- Type: text/html, Size: 639 bytes --]

[-- Attachment #3: Type: text/plain, Size: 68 bytes --]


So Mathieu's LXDE patches can't be checked right now :-(

-- 
Alex

Re: [PATCH] gnu: Add lxappearance.

[Mathieu Lirzin]

Alex Kost <alezost@gmail.com> writes:

> So Mathieu's LXDE patches can't be checked right now :-(

Thanks for looking into it. There is a missing '/' too. I will send a fix
when sourceforge will work again.

Sorry for the mistake, I will be more careful next time.

--
Mathieu Lirzin

Re: [PATCH] gnu: Add lxappearance.

[Mathieu Lirzin]

Fixed in commit 3ab98da1bd91a6d211475a18ba628180071b1a35.

--
Mathieu Lirzin