From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 09/19] gnu: Add r-markdown.
Date: Mon, 14 Sep 2015 13:10:23 +0200 [thread overview]
Message-ID: <87d1xl8deo.fsf@mdc-berlin.de> (raw)
In-Reply-To: <CAMfbzvDp3Hyoqo+LadHC01Nef-FCONyoXwoF_JRjSqVYHFjOsA@mail.gmail.com>
> From 7e291c7f87498368be556941f6eb7315f94a7c74 Mon Sep 17 00:00:00 2001
> From: Vicente Vera Parra <vicentemvp@gmail.com>
> Date: Sun, 13 Sep 2015 13:17:39 -0300
> Subject: [PATCH 09/19] gnu: Add r-markdown.
> * gnu/packages/statistics.scm (r-markdown): New variable.
[...]
> + ;; Skip check phase because the tests require knitr to be
> + ;; installed. Since it won't (markdown is a dependency of the knitr
> + ;; package), installation will fail.
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (delete 'check))))
Two things: 1) the comment isn’t very clear. “Since it won’t” what? Maybe
you can rephrase. 2) Instead of deleting the “check” phase just write
(arguments `(#:tests? #f))
> + (propagated-inputs
> + `(("r-mime" ,r-mime)))
> + (home-page "https://github.com/rstudio/markdown")
> + (synopsis "'Markdown' Rendering for R")
Quoting “Markdown” looks odd. How about just
“Markdown rendering library for R”
> + (description
> + "Provides R bindings to the 'Sundown' 'Markdown' rendering
> +library (https://github.com/vmg/sundown). 'Markdown' is a plain-text
> +formatting syntax that can be converted to 'XHTML' or other formats.
> +See http://en.wikipedia.org/wiki/Markdown for more information about
> +'Markdown'.")
The quoting looks very odd. Does this mean that “Sundown” must be
available at runtime in order to use the “r-markdown” package? If this
is so, shouldn’t a “sundown” package be among the inputs of this
package?
> + (license license:gpl2)))
This appears to be correct. The license headers of the files in the “R”
directory only explicitly mention “version 2”, there is no “or later”
clause. I just wonder what this means for libraries using
“r-markdown”, such as “r-knitr”, which according to your next patch is
supposedly released under “GPLv3+”. IIUC this cannot be the case.
~~ Ricardo
next prev parent reply other threads:[~2015-09-14 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:50 [PATCH 09/19] gnu: Add r-markdown Vicente Vera
2015-09-14 11:10 ` Ricardo Wurmus [this message]
2015-09-14 19:59 ` Vicente Vera
2015-09-15 17:40 ` Vicente Vera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1xl8deo.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=vicentemvp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).