From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 09/19] gnu: Add r-markdown. Date: Mon, 14 Sep 2015 13:10:23 +0200 Message-ID: <87d1xl8deo.fsf@mdc-berlin.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbRec-0004UX-RS for guix-devel@gnu.org; Mon, 14 Sep 2015 07:10:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbReZ-00018z-As for guix-devel@gnu.org; Mon, 14 Sep 2015 07:10:34 -0400 Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:50005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbReZ-00018U-2O for guix-devel@gnu.org; Mon, 14 Sep 2015 07:10:31 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Vicente Vera Cc: guix-devel@gnu.org > From 7e291c7f87498368be556941f6eb7315f94a7c74 Mon Sep 17 00:00:00 2001 > From: Vicente Vera Parra > Date: Sun, 13 Sep 2015 13:17:39 -0300 > Subject: [PATCH 09/19] gnu: Add r-markdown. > * gnu/packages/statistics.scm (r-markdown): New variable. [...] > + ;; Skip check phase because the tests require knitr to be > + ;; installed. Since it won't (markdown is a dependency of the knit= r > + ;; package), installation will fail. > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'check)))) Two things: 1) the comment isn=E2=80=99t very clear. =E2=80=9CSince it w= on=E2=80=99t=E2=80=9D what? Maybe you can rephrase. 2) Instead of deleting the =E2=80=9Ccheck=E2=80=9D pha= se just write (arguments `(#:tests? #f)) > + (propagated-inputs > + `(("r-mime" ,r-mime))) > + (home-page "https://github.com/rstudio/markdown") > + (synopsis "'Markdown' Rendering for R") Quoting =E2=80=9CMarkdown=E2=80=9D looks odd. How about just =E2=80=9CMarkdown rendering library for R=E2=80=9D > + (description > + "Provides R bindings to the 'Sundown' 'Markdown' rendering > +library (https://github.com/vmg/sundown). 'Markdown' is a plain-text > +formatting syntax that can be converted to 'XHTML' or other formats. > +See http://en.wikipedia.org/wiki/Markdown for more information about > +'Markdown'.") The quoting looks very odd. Does this mean that =E2=80=9CSundown=E2=80=9D= must be available at runtime in order to use the =E2=80=9Cr-markdown=E2=80=9D pac= kage? If this is so, shouldn=E2=80=99t a =E2=80=9Csundown=E2=80=9D package be among the= inputs of this package? > + (license license:gpl2))) This appears to be correct. The license headers of the files in the =E2=80= =9CR=E2=80=9D directory only explicitly mention =E2=80=9Cversion 2=E2=80=9D, there is n= o =E2=80=9Cor later=E2=80=9D clause. I just wonder what this means for libraries using =E2=80=9Cr-markdown=E2=80=9D, such as =E2=80=9Cr-knitr=E2=80=9D, which ac= cording to your next patch is supposedly released under =E2=80=9CGPLv3+=E2=80=9D. IIUC this cannot be = the case. ~~ Ricardo