unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: econnman: Add missing input.
@ 2017-01-03 22:15 Clément Lassieur
  2017-01-04  8:07 ` Leo Famulari
  2017-01-07 22:03 ` Ludovic Courtès
  0 siblings, 2 replies; 5+ messages in thread
From: Clément Lassieur @ 2017-01-03 22:15 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/connman.scm (econnman)[inputs]: Add python2-dbus.
---
 gnu/packages/connman.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/connman.scm b/gnu/packages/connman.scm
index 870001237..0fced0be7 100644
--- a/gnu/packages/connman.scm
+++ b/gnu/packages/connman.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2017 Mathieu OTHACEHE <m.othacehe@gmail.com>
+;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -123,6 +124,7 @@ sharing) to clients via USB, ethernet, WiFi, cellular and Bluetooth.")
     (inputs
      `(("efl" ,efl)
        ("python-2" ,python-2)
+       ("python2-dbus" ,python2-dbus)
        ("python2-efl" ,python2-efl)))
     (home-page "https://www.enlightenment.org")
     (synopsis "Connman User Interface written using the EFL")
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: econnman: Add missing input.
  2017-01-03 22:15 [PATCH] gnu: econnman: Add missing input Clément Lassieur
@ 2017-01-04  8:07 ` Leo Famulari
  2017-01-04  9:27   ` Clément Lassieur
  2017-01-07 22:03 ` Ludovic Courtès
  1 sibling, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2017-01-04  8:07 UTC (permalink / raw)
  To: Clément Lassieur; +Cc: guix-devel

On Tue, Jan 03, 2017 at 11:15:31PM +0100, Clément Lassieur wrote:
> * gnu/packages/connman.scm (econnman)[inputs]: Add python2-dbus.

Hi!

What goes wrong without this input? I don't have an Enlightenment
desktop, so I'm not sure how to evaluate this patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: econnman: Add missing input.
  2017-01-04  8:07 ` Leo Famulari
@ 2017-01-04  9:27   ` Clément Lassieur
  2017-01-04 15:32     ` Danny Milosavljevic
  0 siblings, 1 reply; 5+ messages in thread
From: Clément Lassieur @ 2017-01-04  9:27 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

Hi Leo,

> What goes wrong without this input? I don't have an Enlightenment
> desktop, so I'm not sure how to evaluate this patch.

I don't have Enlightenment either. Without this input, I get this error
when I execute econnman-bin:

Traceback (most recent call last):
  File "/gnu/store/65prgdvxzayh2aqhqgi198qv8kacp7bj-econnman-1.1/bin/.econnman-bin-real", line 11, in <module>
    import dbus
ImportError: No module named dbus

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: econnman: Add missing input.
  2017-01-04  9:27   ` Clément Lassieur
@ 2017-01-04 15:32     ` Danny Milosavljevic
  0 siblings, 0 replies; 5+ messages in thread
From: Danny Milosavljevic @ 2017-01-04 15:32 UTC (permalink / raw)
  To: Clément Lassieur; +Cc: guix-devel

On Wed, 04 Jan 2017 10:27:42 +0100
Clément Lassieur <clement@lassieur.org> wrote:
> I don't have Enlightenment either. Without this input, I get this error
> when I execute econnman-bin:

Good enough for me. OK!

I also tested it without the patch, where it failed as described, and with the patch, where it works.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: econnman: Add missing input.
  2017-01-03 22:15 [PATCH] gnu: econnman: Add missing input Clément Lassieur
  2017-01-04  8:07 ` Leo Famulari
@ 2017-01-07 22:03 ` Ludovic Courtès
  1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-01-07 22:03 UTC (permalink / raw)
  To: Clément Lassieur; +Cc: guix-devel

Clément Lassieur <clement@lassieur.org> skribis:

> * gnu/packages/connman.scm (econnman)[inputs]: Add python2-dbus.

Pushed.  Thanks Clément & Danny!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-01-07 22:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 22:15 [PATCH] gnu: econnman: Add missing input Clément Lassieur
2017-01-04  8:07 ` Leo Famulari
2017-01-04  9:27   ` Clément Lassieur
2017-01-04 15:32     ` Danny Milosavljevic
2017-01-07 22:03 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).