From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Leo Famulari <leo@famulari.name>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Packaging gx (for IPFS): Need to update default Go to 1.11?
Date: Wed, 07 Nov 2018 21:48:50 +0100 [thread overview]
Message-ID: <87d0rgmx59.fsf@ambrevar.xyz> (raw)
In-Reply-To: <20181107204054.GA29657@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
> Yes, we should, but that problem is not related to packages not building
> with Go 1.11 because they need to be updated upstream, right? Even if
> our go-build-system was updated, those packages would still need to be
> built with Go 1.9? Or did I misunderstand?
In my patchset, there are 2 kinds of fixes:
- Disabling tests because Go 1.11 test policies are stricter and some lax code
from before does not pass anymore.
For this issue, upstream should fix their packages. As far as we are
concerned, disabling tests is enough. The go-build-system has nothing to do
with this issue.
- Manual forwarding of compilation flags (e.g. "-tags"). This is an issue with
our go-build-system which cannot re-use existing "pkg" objects on Go 1.11.
Upstream code is fine.
So yes, fixing go-build-system is related to packages not building with
Go 1.11 :p
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-11-07 20:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 11:40 Packaging gx (for IPFS): Need to update default Go to 1.11? Pierre Neidhardt
2018-10-24 11:42 ` Pierre Neidhardt
2018-10-24 13:55 ` Leo Famulari
2018-10-24 14:02 ` Pierre Neidhardt
2018-10-24 14:14 ` Leo Famulari
2018-11-06 11:56 ` Pierre Neidhardt
2018-11-06 12:03 ` Pierre Neidhardt
2018-11-06 17:04 ` Pierre Neidhardt
2018-11-06 17:31 ` Leo Famulari
2018-11-06 17:33 ` Pierre Neidhardt
2018-11-06 19:57 ` Leo Famulari
2018-11-07 7:33 ` Pierre Neidhardt
2018-11-07 16:22 ` Pierre Neidhardt
2018-11-07 18:26 ` Leo Famulari
2018-11-07 20:09 ` Pierre Neidhardt
2018-11-07 20:40 ` Leo Famulari
2018-11-07 20:48 ` Pierre Neidhardt [this message]
2018-11-07 21:03 ` Leo Famulari
2018-11-11 16:43 ` Pierre Neidhardt
2018-11-11 20:52 ` Pierre Neidhardt
2018-11-11 21:33 ` Pierre Neidhardt
2018-11-12 9:45 ` Pierre Neidhardt
2018-11-12 17:33 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0rgmx59.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).