From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Packaging gx (for IPFS): Need to update default Go to 1.11? Date: Wed, 07 Nov 2018 21:48:50 +0100 Message-ID: <87d0rgmx59.fsf@ambrevar.xyz> References: <87efbyberv.fsf@ambrevar.xyz> <87d0ribeg2.fsf@ambrevar.xyz> <878t26b0i1.fsf@ambrevar.xyz> <20181106173116.GA3232@jasmine.lan> <87k1lqyuta.fsf@ambrevar.xyz> <20181106195712.GB6749@jasmine.lan> <87a7mlz6hv.fsf@ambrevar.xyz> <87o9b0n9gr.fsf@ambrevar.xyz> <20181107182642.GA17483@jasmine.lan> <87efbwmyyz.fsf@ambrevar.xyz> <20181107204054.GA29657@jasmine.lan> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKUl3-0002oh-Ul for guix-devel@gnu.org; Wed, 07 Nov 2018 15:49:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKUky-0008P4-WF for guix-devel@gnu.org; Wed, 07 Nov 2018 15:49:01 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34879) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKUky-0008OU-PP for guix-devel@gnu.org; Wed, 07 Nov 2018 15:48:56 -0500 In-reply-to: <20181107204054.GA29657@jasmine.lan> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: Guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Yes, we should, but that problem is not related to packages not building > with Go 1.11 because they need to be updated upstream, right? Even if > our go-build-system was updated, those packages would still need to be > built with Go 1.9? Or did I misunderstand? In my patchset, there are 2 kinds of fixes: =2D Disabling tests because Go=C2=A01.11 test policies are stricter and som= e lax code from before does not pass anymore. For this issue, upstream should fix their packages. As far as we are concerned, disabling tests is enough. The go-build-system has nothing to= do with this issue. =2D Manual forwarding of compilation flags (e.g. "-tags"). This is an issu= e with our go-build-system which cannot re-use existing "pkg" objects on Go=C2= =A01.11. Upstream code is fine. So yes, fixing go-build-system is related to packages not building with Go=C2=A01.11=C2=A0:p =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlvjT7IACgkQm9z0l6S7 zH8V+Qf/U3v7a3244HaVW3TlatUAFE/Vhsc6HfyKEsAZ+c7sXFiSlqLGGfUyhhCg v/p3K8MvemCiq1uZaJ1MudYzURvOxF4PZB1DJCbCcuXBxsje4BwbG68aSI513EUT bM1I4GF6vyo0nLzyS58vz4GRrppdk2xKqOhbqWWRqlpbtKZ4VEC6Y33rsgnC+5PJ QUDmbSRIHdc67swJCQN0JkwdvhcoONVA1CHE8Ph7Ht5d5WUa/DwSdllxI2Xm3sAJ ZowHN+FM8QmhoNDQZpNJGwmDDg2D2TUEikhpJpAnXBBpkK/CMaKr3jba3+T/Yf3D QD4a/2XwQF60YDsY+q8lH7koOoz1SQ== =/vcZ -----END PGP SIGNATURE----- --=-=-=--